This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (whal != 0 && (ha != ven || a || fle)) {
...
...
// Pretend there is lots of code here
...
...
} else {
ostrur();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (!fle && !a && ha == ven || whal == 0) {
ostrur();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (olad || pirm()) {
if (ineDaad() && solci()) {
if (solci()) {
return true;
}
if (fri) {
return true;
}
}
}
return false;
return (fri || ineDaad()) && solci() || olad || pirm();
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (!ineDaad() && !fri) {
if (!solci()) {
return false;
}
}
if (!olad) {
return false;
}
if (!pirm()) {
return false;
}
return true;
Simplify the following messy chain of conditionals:
if (di == false) {
secim();
}
if (goul > 1 && di != false) {
dopel();
} else if (gass < e && di != false && goul < 1) {
reuFeraur();
}
if (di != false && goul < 1 && gass > e) {
fospes();
}
{
if (!di) {
secim();
}
if (goul > 1) {
dopel();
}
if (gass < e) {
reuFeraur();
}
fospes();
}
Things to double-check in your solution:
== true and == false checks?else, no final if.Related puzzles: