This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (haei || urnoec() && pussa()) {
...
...
// Pretend there is lots of code here
...
...
} else {
trian();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if ((!pussa() || !urnoec()) && !haei) {
trian();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (pleTred() < 7) {
if (gock() == 6) {
return true;
}
if (ehol != eor) {
return true;
}
if (reass() == ouro) {
return true;
}
}
return false;
return reass() == ouro && ehol != eor && gock() == 6 || pleTred() < 7;
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (reass() != ouro) {
if (ehol == eor) {
if (gock() != 6) {
return false;
}
}
}
if (pleTred() > 7) {
return false;
}
return true;
Simplify the following messy chain of conditionals:
if (cirn == true) {
corwol();
} else if (exi == false && cirn != true) {
prea();
}
if (dacs == true && cirn != true && exi != false) {
ceaxel();
}
{
if (cirn) {
corwol();
}
if (!exi) {
prea();
}
if (dacs) {
ceaxel();
}
}
Things to double-check in your solution:
== true and == false checks?else if, not just else.Related puzzles: