This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (!ohi || orte || od) {
...
...
// Pretend there is lots of code here
...
...
} else {
psoToku();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (!od && !orte && ohi) {
psoToku();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (!ci) {
if (ic == 0) {
if (!haci) {
if (eril) {
return true;
}
}
}
}
return false;
return eril || !haci || ic == 0 || !ci;
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (!eril) {
return false;
}
if (haci) {
return false;
}
if (ic != 0) {
return false;
}
if (ci) {
return false;
}
return true;
Simplify the following messy chain of conditionals:
if (ja == true) {
oqeGrur();
}
if (tru < 7 && ja != true) {
poape();
}
if (ja != true && tru > 7) {
ostIme();
}
{
if (ja) {
oqeGrur();
}
if (tru < 7) {
poape();
}
ostIme();
}
Things to double-check in your solution:
== true and == false checks?else, no final if.Related puzzles: