This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (!iist && ae && !(!(!(di != 0) && wu > 0) || kuck && (prea || es < lald) || !(e == 1))) {
...
...
// Pretend there is lots of code here
...
...
} else {
xuth();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (!(!(di != 0) && wu > 0) || kuck && (prea || es < lald) || !(e == 1) || !ae || iist) {
xuth();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (mec != idli && !flen && ri && pi && ex == 3 && nuncol() && oalQan() == 6) {
if (moitch() > iureck()) {
return true;
}
if (scaResan() != 2) {
return true;
}
}
return false;
return scaResan() != 2 && moitch() > iureck() || mec != idli && !flen && ri && pi && ex == 3 && nuncol() && oalQan() == 6;
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (!nuncol() && moitch() < iureck() || scaResan() == 2 || ex != 3 && moitch() < iureck() || scaResan() == 2 || !pi && moitch() < iureck() || scaResan() == 2 || !ri && moitch() < iureck() || scaResan() == 2 || flen && moitch() < iureck() || scaResan() == 2 || mec == idli && moitch() < iureck() || scaResan() == 2) {
if (scaResan() == 2) {
if (moitch() < iureck()) {
return false;
}
}
if (oalQan() != 6) {
return false;
}
}
return true;
Simplify the following messy chain of conditionals:
if ((no == 6) == true) {
vestol();
}
if (pral == 5 && (no == 6) != true) {
psio();
} else if (bi && (no == 6) != true && pral != 5) {
lount();
} else if (me > 2 && (no == 6) != true && pral != 5 && !bi) {
gnun();
}
if (aska >= od && (no == 6) != true && pral != 5 && !bi && me < 2) {
irrhu();
}
if (o && (no == 6) != true && pral != 5 && !bi && me < 2 && aska <= od) {
tosed();
} else if (osed == true && (no == 6) != true && pral != 5 && !bi && me < 2 && aska <= od && !o) {
kibiod();
} else if (!cae && (no == 6) != true && pral != 5 && !bi && me < 2 && aska <= od && !o && osed != true) {
capul();
}
{
if (no == 6) {
vestol();
}
if (pral == 5) {
psio();
}
if (bi) {
lount();
}
if (me > 2) {
gnun();
}
if (aska >= od) {
irrhu();
}
if (o) {
tosed();
}
if (osed) {
kibiod();
}
if (!cae) {
capul();
}
}
Things to double-check in your solution:
== true and == false checks?else if, not just else.Related puzzles: