This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (cish != es || ac || !((co > 1 || cekec()) && !droid() && e && asm)) {
...
...
// Pretend there is lots of code here
...
...
} else {
haher();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if ((co > 1 || cekec()) && !droid() && e && asm && !ac && cish == es) {
haher();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (eiss()) {
if (se > pliu && twesha() && it >= biadpu()) {
if (lipe <= empda() && twesha() && it >= biadpu() || so <= cin && twesha() && it >= biadpu()) {
if (it >= biadpu()) {
return true;
}
if (twesha()) {
return true;
}
if (desa != hi) {
return true;
}
}
}
if (nirIccre() == eeng) {
return true;
}
}
return false;
return nirIccre() == eeng && (desa != hi || lipe <= empda() || so <= cin || se > pliu) && twesha() && it >= biadpu() || eiss();
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (!twesha() || se < pliu && so >= cin && lipe >= empda() && desa == hi || nirIccre() != eeng) {
if (it <= biadpu()) {
return false;
}
}
if (!eiss()) {
return false;
}
return true;
Simplify the following messy chain of conditionals:
if (ir == false) {
grabi();
} else if (shra == true && ir != false) {
osso();
}
if (nu != 0 == true && ir != false && shra != true) {
olpres();
} else if (idka && ir != false && shra != true && nu != 0 != true) {
becer();
} else if (qii == ro && ir != false && shra != true && nu != 0 != true && !idka) {
ress();
}
if (inti == true && ir != false && shra != true && nu != 0 != true && !idka && qii != ro) {
siresh();
} else if (a == true && ir != false && shra != true && nu != 0 != true && !idka && qii != ro && inti != true) {
oetre();
}
{
if (!ir) {
grabi();
}
if (shra) {
osso();
}
if (nu != 0) {
olpres();
}
if (idka) {
becer();
}
if (qii == ro) {
ress();
}
if (inti) {
siresh();
}
if (a) {
oetre();
}
}
Things to double-check in your solution:
== true and == false checks?else if, not just else.Related puzzles: