This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (ismu() == nuss && jico() && da || jes || choume() || whi || eo == 2 && (prast() || on) && !(i == 1 || biobo())) {
...
...
// Pretend there is lots of code here
...
...
} else {
trene();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if ((i == 1 || biobo() || !on && !prast() || eo != 2) && !whi && !choume() && !jes && (!da || !jico() || ismu() != nuss)) {
trene();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (!ript && pra && !pid && ni || occie() && ni || !id && ni || cadnam() && pra && !pid && ni || occie() && ni || !id && ni) {
if (rotnad() && widsel()) {
if (ta == tuhe) {
return true;
}
if (heent()) {
return true;
}
if (cror() == lada()) {
return true;
}
}
}
return false;
return cror() == lada() && heent() && ta == tuhe || rotnad() && widsel() || (!ript || cadnam()) && pra && (!pid || occie() || !id) && ni;
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (id && !occie() && pid && !widsel() && ta != tuhe || !heent() || cror() != lada() || !rotnad() && ta != tuhe || !heent() || cror() != lada() || !pra && !widsel() && ta != tuhe || !heent() || cror() != lada() || !rotnad() && ta != tuhe || !heent() || cror() != lada() || !cadnam() && ript && !widsel() && ta != tuhe || !heent() || cror() != lada() || !rotnad() && ta != tuhe || !heent() || cror() != lada()) {
if (!rotnad() && ta != tuhe || !heent() || cror() != lada()) {
if (cror() != lada()) {
if (!heent()) {
if (ta != tuhe) {
return false;
}
}
}
if (!widsel()) {
return false;
}
}
if (!ni) {
return false;
}
}
return true;
Simplify the following messy chain of conditionals:
if (en != gua) {
tulSeesh();
} else if (cile == true && en == gua) {
enal();
} else if (cu > coro == true && en == gua && cile != true) {
oenOsbe();
} else if (kes == 0 && en == gua && cile != true && cu > coro != true) {
edis();
} else if (sca == false && en == gua && cile != true && cu > coro != true && kes != 0) {
stidi();
}
if (ed == true && en == gua && cile != true && cu > coro != true && kes != 0 && sca != false) {
sanma();
}
if (acni && en == gua && cile != true && cu > coro != true && kes != 0 && sca != false && ed != true) {
oppel();
} else if (irhe == true && en == gua && cile != true && cu > coro != true && kes != 0 && sca != false && ed != true && !acni) {
cacWulpe();
}
if (ce <= 5 && en == gua && cile != true && cu > coro != true && kes != 0 && sca != false && ed != true && !acni && irhe != true) {
stou();
} else if (aci == true && en == gua && cile != true && cu > coro != true && kes != 0 && sca != false && ed != true && !acni && irhe != true && ce >= 5) {
biclin();
} else if (en == gua && cile != true && cu > coro != true && kes != 0 && sca != false && ed != true && !acni && irhe != true && ce >= 5 && aci != true) {
boiTric();
}
{
if (en != gua) {
tulSeesh();
}
if (cile) {
enal();
}
if (cu > coro) {
oenOsbe();
}
if (kes == 0) {
edis();
}
if (!sca) {
stidi();
}
if (ed) {
sanma();
}
if (acni) {
oppel();
}
if (irhe) {
cacWulpe();
}
if (ce <= 5) {
stou();
}
if (aci) {
biclin();
}
boiTric();
}
Things to double-check in your solution:
== true and == false checks?else, no final if.Related puzzles: