This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (glooir() == 4 && !cin && en && !rul || trar() && e) {
...
...
// Pretend there is lots of code here
...
...
} else {
lodi();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if ((!e || !trar()) && (rul || !en || cin || glooir() != 4)) {
lodi();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (ia && eca != 7 && prac && desan() || chitho() && prac && desan() || godus() == meefi() && prac && desan()) {
if (awoc()) {
return true;
}
}
return false;
return awoc() || (ia && eca != 7 || chitho() || godus() == meefi()) && prac && desan();
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (godus() != meefi() && !chitho() && eca == 7 && !awoc() || !ia && !awoc()) {
if (!prac && !awoc()) {
if (!awoc()) {
return false;
}
if (!desan()) {
return false;
}
}
}
return true;
Simplify the following messy chain of conditionals:
if (esm > 8) {
priReuas();
} else if (os == a && esm < 8) {
orkes();
}
if (phe == true && esm < 8 && os != a) {
cioun();
} else if (al == true && esm < 8 && os != a && phe != true) {
auxi();
}
if (tia && esm < 8 && os != a && phe != true && al != true) {
troes();
}
if (ge == true && esm < 8 && os != a && phe != true && al != true && !tia) {
noli();
}
{
if (esm > 8) {
priReuas();
}
if (os == a) {
orkes();
}
if (phe) {
cioun();
}
if (al) {
auxi();
}
if (tia) {
troes();
}
if (ge) {
noli();
}
}
Things to double-check in your solution:
== true and == false checks?else if, not just else.Related puzzles: