This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (lenged() && !hio && oism || pisp()) {
...
...
// Pretend there is lots of code here
...
...
} else {
hirpra();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (!pisp() && (!oism || hio || !lenged())) {
hirpra();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (kopse()) {
if (cudi() == 1) {
return true;
}
}
if (soton()) {
return true;
}
if (chreng() != 5) {
return true;
}
if (laa == 0) {
return true;
}
return false;
return laa == 0 && chreng() != 5 && soton() && (cudi() == 1 || kopse());
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (!soton() || chreng() == 5 || laa != 0) {
if (cudi() != 1) {
return false;
}
if (!kopse()) {
return false;
}
}
return true;
Simplify the following messy chain of conditionals:
if (acda != 7 == true) {
pitswe();
} else if (inis == true && acda != 7 != true) {
mesac();
} else if (vard <= 2 && acda != 7 != true && inis != true) {
meff();
} else if (acda != 7 != true && inis != true && vard >= 2) {
oenEngect();
}
{
if (acda != 7) {
pitswe();
}
if (inis) {
mesac();
}
if (vard <= 2) {
meff();
}
oenEngect();
}
Things to double-check in your solution:
== true and == false checks?else, no final if.Related puzzles: