This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (doop() || se || pleSalgit() || gla == 7 || eleSisa() || cawe >= 7) {
...
...
// Pretend there is lots of code here
...
...
} else {
wasm();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (cawe <= 7 && !eleSisa() && gla != 7 && !pleSalgit() && !se && !doop()) {
wasm();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (thel()) {
if (swiClaess() <= 7 || erlo || ir) {
if (psu == 3 && !co) {
if (!co) {
return true;
}
if (riou() == 8) {
return true;
}
}
}
}
return false;
return (riou() == 8 || psu == 3) && !co || swiClaess() <= 7 || erlo || ir || thel();
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (psu != 3 && riou() != 8) {
if (co) {
return false;
}
}
if (swiClaess() >= 7) {
return false;
}
if (!erlo) {
return false;
}
if (!ir) {
return false;
}
if (!thel()) {
return false;
}
return true;
Simplify the following messy chain of conditionals:
if (crur == true) {
ress();
}
if (le == true && crur != true) {
actiss();
}
if (we == true && crur != true && le != true) {
chero();
} else if (mi && crur != true && le != true && we != true) {
onstem();
}
if (so && crur != true && le != true && we != true && !mi) {
nish();
} else if (crur != true && le != true && we != true && !mi && !so) {
ontla();
}
{
if (crur) {
ress();
}
if (le) {
actiss();
}
if (we) {
chero();
}
if (mi) {
onstem();
}
if (so) {
nish();
}
ontla();
}
Things to double-check in your solution:
== true and == false checks?else, no final if.Related puzzles: