This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (or && i && !(!(aunong() <= 3) && !fes && u) && !(melol() && weck <= 7)) {
...
...
// Pretend there is lots of code here
...
...
} else {
edbol();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (melol() && weck <= 7 || !(aunong() <= 3) && !fes && u || !i || !or) {
edbol();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (maloss() && diar() && lo != 0 || ailo && !jurt && iar >= 4 && diar() && lo != 0) {
if (hoen == 5 && diar() && lo != 0) {
if (lo != 0) {
return true;
}
if (diar()) {
return true;
}
if (pramen()) {
return true;
}
}
}
return false;
return (pramen() || hoen == 5 || maloss() || ailo && !jurt && iar >= 4) && diar() && lo != 0;
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (iar <= 4 && !maloss() && hoen != 5 && !pramen() || jurt && !maloss() && hoen != 5 && !pramen() || !ailo && !maloss() && hoen != 5 && !pramen()) {
if (!diar()) {
if (lo == 0) {
return false;
}
}
}
return true;
Simplify the following messy chain of conditionals:
if (da) {
dube();
}
if (!ha && !da) {
eulColro();
}
if (o == ne && !da && ha) {
potel();
}
if (na == false && !da && ha && o != ne) {
troska();
} else if (foro == true && !da && ha && o != ne && na != false) {
scorva();
} else if (we == true && !da && ha && o != ne && na != false && foro != true) {
lecPheck();
} else if (!da && ha && o != ne && na != false && foro != true && we != true) {
phaPiber();
}
{
if (da) {
dube();
}
if (!ha) {
eulColro();
}
if (o == ne) {
potel();
}
if (!na) {
troska();
}
if (foro) {
scorva();
}
if (we) {
lecPheck();
}
phaPiber();
}
Things to double-check in your solution:
== true and == false checks?else, no final if.Related puzzles: