This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (!ba || hi == pti && sli && walCedvan() < ca && edla == i && nie == 0 && pisssi() == 9 && (plaSidhi() == 6 || phand()) && stai() != 8 || o) {
...
...
// Pretend there is lots of code here
...
...
} else {
priFelec();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (!o && (stai() == 8 || !phand() && plaSidhi() != 6 || pisssi() != 9 || nie != 0 || edla != i || walCedvan() > ca || !sli || hi != pti) && ba) {
priFelec();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (onun() == amost() || ro || uxor && an < 2 && mious()) {
if (!ia) {
return true;
}
if (nass()) {
return true;
}
}
if (iac >= 0) {
return true;
}
if (atz <= 3) {
return true;
}
if (he == micUrin()) {
return true;
}
if (id != eriw) {
return true;
}
if (hiass()) {
return true;
}
return false;
return hiass() && id != eriw && he == micUrin() && atz <= 3 && iac >= 0 && (nass() && !ia || onun() == amost() || ro || uxor && an < 2 && mious());
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (atz >= 3 || he != micUrin() || id == eriw || !hiass()) {
if (iac <= 0) {
if (!uxor && !ro && onun() != amost() && ia || !nass()) {
if (an > 2 && !ro && onun() != amost() && ia || !nass()) {
if (!nass()) {
if (ia) {
return false;
}
}
if (onun() != amost()) {
return false;
}
if (!ro) {
return false;
}
if (!mious()) {
return false;
}
}
}
}
}
return true;
Simplify the following messy chain of conditionals:
if (ea) {
usme();
}
if (miol == true && !ea) {
jieso();
}
if (cim == true && !ea && miol != true) {
soiphi();
} else if (!snal && !ea && miol != true && cim != true) {
tieglu();
} else if (cex == true && !ea && miol != true && cim != true && snal) {
efrung();
}
if (ejac == true && !ea && miol != true && cim != true && snal && cex != true) {
noposs();
}
if (!si && !ea && miol != true && cim != true && snal && cex != true && ejac != true) {
thris();
} else if (geza > 0 && !ea && miol != true && cim != true && snal && cex != true && ejac != true && si) {
angMudeng();
}
if (prar && !ea && miol != true && cim != true && snal && cex != true && ejac != true && si && geza < 0) {
onpu();
}
if (bous != 7 && !ea && miol != true && cim != true && snal && cex != true && ejac != true && si && geza < 0 && !prar) {
riste();
}
if (ic && !ea && miol != true && cim != true && snal && cex != true && ejac != true && si && geza < 0 && !prar && bous == 7) {
cundad();
}
{
if (ea) {
usme();
}
if (miol) {
jieso();
}
if (cim) {
soiphi();
}
if (!snal) {
tieglu();
}
if (cex) {
efrung();
}
if (ejac) {
noposs();
}
if (!si) {
thris();
}
if (geza > 0) {
angMudeng();
}
if (prar) {
onpu();
}
if (bous != 7) {
riste();
}
if (ic) {
cundad();
}
}
Things to double-check in your solution:
== true and == false checks?else if, not just else.Related puzzles: