This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if ((!ia || !dac) && ((irgo() || padu || mieDio() || malpo() || i > dadmi() || a != 5) && !as || es || om)) {
...
...
// Pretend there is lots of code here
...
...
} else {
othi();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (!om && !es && (as || a == 5 && i < dadmi() && !malpo() && !mieDio() && !padu && !irgo()) || dac && ia) {
othi();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (!crol) {
if (tac || casIngin() != 1 && cil || mion() && cil) {
if (shae) {
if (onga != esa) {
if (so && pri && ai >= 0 || keva()) {
if (uasess()) {
return true;
}
}
}
}
}
}
return false;
return uasess() || so && pri && (ai >= 0 || keva()) || onga != esa || shae || tac || (casIngin() != 1 || mion()) && cil || !crol;
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (!mion() && casIngin() == 1 && !tac && !shae && onga == esa && !keva() && ai <= 0 && !uasess() || !pri && !uasess() || !so && !uasess()) {
if (!pri && !uasess() || !so && !uasess()) {
if (!uasess()) {
return false;
}
if (ai <= 0) {
return false;
}
if (!keva()) {
return false;
}
}
if (onga == esa) {
return false;
}
if (!shae) {
return false;
}
if (!tac) {
return false;
}
if (!cil) {
return false;
}
}
if (crol) {
return false;
}
return true;
Simplify the following messy chain of conditionals:
if ((en != 9) == true) {
iang();
} else if (ga == true && (en != 9) != true) {
stetda();
}
if (!si && (en != 9) != true && ga != true) {
treama();
} else if (feou == 0 && (en != 9) != true && ga != true && si) {
othrar();
}
if (re && (en != 9) != true && ga != true && si && feou != 0) {
irnell();
} else if (e == true && (en != 9) != true && ga != true && si && feou != 0 && !re) {
cicde();
}
if (bir == false && (en != 9) != true && ga != true && si && feou != 0 && !re && e != true) {
nerBisag();
} else if (rer == true && (en != 9) != true && ga != true && si && feou != 0 && !re && e != true && bir != false) {
muad();
} else if (mour < 1 && (en != 9) != true && ga != true && si && feou != 0 && !re && e != true && bir != false && rer != true) {
whean();
} else if (cem < 9 && (en != 9) != true && ga != true && si && feou != 0 && !re && e != true && bir != false && rer != true && mour > 1) {
olfang();
} else if (thet == false && (en != 9) != true && ga != true && si && feou != 0 && !re && e != true && bir != false && rer != true && mour > 1 && cem > 9) {
rucPeirk();
}
{
if (en != 9) {
iang();
}
if (ga) {
stetda();
}
if (!si) {
treama();
}
if (feou == 0) {
othrar();
}
if (re) {
irnell();
}
if (e) {
cicde();
}
if (!bir) {
nerBisag();
}
if (rer) {
muad();
}
if (mour < 1) {
whean();
}
if (cem < 9) {
olfang();
}
if (!thet) {
rucPeirk();
}
}
Things to double-check in your solution:
== true and == false checks?else if, not just else.Related puzzles: