This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (heasm() || eou || !eia || !de && !(su || icso) && inhou() && mo && (zau || e || anark() >= 8)) {
...
...
// Pretend there is lots of code here
...
...
} else {
spie();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if ((anark() <= 8 && !e && !zau || !mo || !inhou() || su || icso || de) && eia && !eou && !heasm()) {
spie();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (theho() && soshi() && iambor() && eagli() && slasm() && acra() && wum && hi == 3 || scro() && hi == 3 || neass() != on && wum && hi == 3 || scro() && hi == 3 || awuc > siat && soshi() && iambor() && eagli() && slasm() && acra() && wum && hi == 3 || scro() && hi == 3 || neass() != on && wum && hi == 3 || scro() && hi == 3) {
if (neass() != on && wum && hi == 3 || scro() && hi == 3) {
if (scro() && hi == 3) {
if (hi == 3) {
return true;
}
if (wum) {
return true;
}
}
if (acra()) {
return true;
}
if (slasm()) {
return true;
}
}
if (eagli()) {
return true;
}
if (iambor()) {
return true;
}
if (soshi()) {
return true;
}
if (troo > 0) {
return true;
}
}
return false;
return (troo > 0 || theho() || awuc > siat) && soshi() && iambor() && eagli() && (slasm() && acra() || neass() != on) && (wum || scro()) && hi == 3;
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (!soshi() || awuc < siat && !theho() && troo < 0) {
if (!iambor()) {
if (neass() == on && !acra() || !slasm() || !eagli()) {
if (!scro() && !wum) {
if (hi != 3) {
return false;
}
}
}
}
}
return true;
Simplify the following messy chain of conditionals:
if (i == true) {
hetron();
} else if (tre == false && i != true) {
peim();
}
if (bir == true && i != true && tre != false) {
khed();
} else if (tro == false && i != true && tre != false && bir != true) {
lelMaqung();
} else if (dass == true && i != true && tre != false && bir != true && tro != false) {
povan();
} else if (psan == true && i != true && tre != false && bir != true && tro != false && dass != true) {
twiga();
} else if (ciss == true && i != true && tre != false && bir != true && tro != false && dass != true && psan != true) {
toism();
}
if (hil == true && i != true && tre != false && bir != true && tro != false && dass != true && psan != true && ciss != true) {
osost();
} else if (meda == false && i != true && tre != false && bir != true && tro != false && dass != true && psan != true && ciss != true && hil != true) {
geghe();
} else if (scin && i != true && tre != false && bir != true && tro != false && dass != true && psan != true && ciss != true && hil != true && meda != false) {
pesm();
}
if (i != true && tre != false && bir != true && tro != false && dass != true && psan != true && ciss != true && hil != true && meda != false && !scin) {
clalud();
}
{
if (i) {
hetron();
}
if (!tre) {
peim();
}
if (bir) {
khed();
}
if (!tro) {
lelMaqung();
}
if (dass) {
povan();
}
if (psan) {
twiga();
}
if (ciss) {
toism();
}
if (hil) {
osost();
}
if (!meda) {
geghe();
}
if (scin) {
pesm();
}
clalud();
}
Things to double-check in your solution:
== true and == false checks?else, no final if.Related puzzles: