This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (rhi || adi == 0 || issbae() || dangdo() && !us || (!cle && cegs() || !(gisfi() || pe)) && !re || uss != 5) {
...
...
// Pretend there is lots of code here
...
...
} else {
voend();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (uss == 5 && (re || (gisfi() || pe) && (!cegs() || cle)) && (us || !dangdo()) && !issbae() && adi != 0 && !rhi) {
voend();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (liie >= 4 && !buc && !pamp || di != 5 && !o && dic <= scuEslul() || plid() == eod && !o && dic <= scuEslul()) {
if (itz && a || !ei || mebe) {
if (mebe) {
if (!ei) {
if (a) {
return true;
}
}
}
if (ixhol() <= 6) {
return true;
}
}
}
return false;
return (ixhol() <= 6 || itz) && (a || !ei || mebe) || liie >= 4 && !buc && (!pamp || (di != 5 || plid() == eod) && !o && dic <= scuEslul());
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (liie <= 4 && !mebe && ei && !a || !itz && ixhol() >= 6) {
if (buc && !mebe && ei && !a || !itz && ixhol() >= 6) {
if (plid() != eod && di == 5 && pamp && !mebe && ei && !a || !itz && ixhol() >= 6) {
if (o && pamp && !mebe && ei && !a || !itz && ixhol() >= 6) {
if (!itz && ixhol() >= 6) {
if (!a) {
return false;
}
if (ei) {
return false;
}
if (!mebe) {
return false;
}
}
if (pamp) {
return false;
}
if (dic >= scuEslul()) {
return false;
}
}
}
}
}
return true;
Simplify the following messy chain of conditionals:
if (flin == true) {
iarsu();
}
if (ril == true && flin != true) {
taec();
} else if (unec == true && flin != true && ril != true) {
cotpo();
}
if (ta != 5 && flin != true && ril != true && unec != true) {
ladi();
} else if (se == true && flin != true && ril != true && unec != true && ta == 5) {
ioler();
} else if (bi == true && flin != true && ril != true && unec != true && ta == 5 && se != true) {
rass();
}
if (me == true && flin != true && ril != true && unec != true && ta == 5 && se != true && bi != true) {
engo();
} else if (on == true && flin != true && ril != true && unec != true && ta == 5 && se != true && bi != true && me != true) {
iwnan();
}
if (rupe == true && flin != true && ril != true && unec != true && ta == 5 && se != true && bi != true && me != true && on != true) {
uisma();
} else if (i == false && flin != true && ril != true && unec != true && ta == 5 && se != true && bi != true && me != true && on != true && rupe != true) {
rorman();
} else if (apee && flin != true && ril != true && unec != true && ta == 5 && se != true && bi != true && me != true && on != true && rupe != true && i != false) {
travid();
}
{
if (flin) {
iarsu();
}
if (ril) {
taec();
}
if (unec) {
cotpo();
}
if (ta != 5) {
ladi();
}
if (se) {
ioler();
}
if (bi) {
rass();
}
if (me) {
engo();
}
if (on) {
iwnan();
}
if (rupe) {
uisma();
}
if (!i) {
rorman();
}
if (apee) {
travid();
}
}
Things to double-check in your solution:
== true and == false checks?else if, not just else.Related puzzles: