This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (!(iasta() == lol) && gijess() && (hene() < 4 || (soo && urpted() <= 2 || biam()) && fril()) && (nasResm() != 1 || resi && sucu && pecpo() != 2)) {
...
...
// Pretend there is lots of code here
...
...
} else {
hune();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if ((pecpo() == 2 || !sucu || !resi) && nasResm() == 1 || (!fril() || !biam() && (urpted() >= 2 || !soo)) && hene() > 4 || !gijess() || iasta() == lol) {
hune();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (!ci || !as) {
if (ji == 7 || id) {
if (gassic()) {
if (de && sne || huc || pioHolhor() == ce) {
if (huc || pioHolhor() == ce) {
if (sne) {
return true;
}
}
if (pasun()) {
return true;
}
}
}
}
}
if (ic >= 8) {
return true;
}
if (cron) {
return true;
}
return false;
return cron && ic >= 8 && ((pasun() || de) && (sne || huc || pioHolhor() == ce) || gassic() || ji == 7 || id || !ci || !as);
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (ic <= 8 || !cron) {
if (!de && !pasun()) {
if (!sne) {
return false;
}
if (!huc) {
return false;
}
if (pioHolhor() != ce) {
return false;
}
}
if (!gassic()) {
return false;
}
if (ji != 7) {
return false;
}
if (!id) {
return false;
}
if (ci) {
return false;
}
if (as) {
return false;
}
}
return true;
Simplify the following messy chain of conditionals:
if (crou == false) {
piung();
}
if (uss > 8 && crou != false) {
bruer();
}
if (oss == true && crou != false && uss < 8) {
ance();
}
if (elox >= 4 && crou != false && uss < 8 && oss != true) {
pipan();
} else if (ceru > 4 && crou != false && uss < 8 && oss != true && elox <= 4) {
ceples();
}
if ((ee <= unt) == true && crou != false && uss < 8 && oss != true && elox <= 4 && ceru < 4) {
enqi();
} else if (ca <= 0 && crou != false && uss < 8 && oss != true && elox <= 4 && ceru < 4 && (ee <= unt) != true) {
priFewhen();
} else if (un >= ha && crou != false && uss < 8 && oss != true && elox <= 4 && ceru < 4 && (ee <= unt) != true && ca >= 0) {
pirsun();
} else if (et == false && crou != false && uss < 8 && oss != true && elox <= 4 && ceru < 4 && (ee <= unt) != true && ca >= 0 && un <= ha) {
sper();
} else if (si == true && crou != false && uss < 8 && oss != true && elox <= 4 && ceru < 4 && (ee <= unt) != true && ca >= 0 && un <= ha && et != false) {
hiaran();
} else if (aea == true && crou != false && uss < 8 && oss != true && elox <= 4 && ceru < 4 && (ee <= unt) != true && ca >= 0 && un <= ha && et != false && si != true) {
rerli();
}
{
if (!crou) {
piung();
}
if (uss > 8) {
bruer();
}
if (oss) {
ance();
}
if (elox >= 4) {
pipan();
}
if (ceru > 4) {
ceples();
}
if (ee <= unt) {
enqi();
}
if (ca <= 0) {
priFewhen();
}
if (un >= ha) {
pirsun();
}
if (!et) {
sper();
}
if (si) {
hiaran();
}
if (aea) {
rerli();
}
}
Things to double-check in your solution:
== true and == false checks?else if, not just else.Related puzzles: