This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (krof() > 6 && phir() && !(!inpe && (pnast() && cismoc() || pibe != 8) && iswi() == 7 && (pra || doi && jor) && !ar)) {
...
...
// Pretend there is lots of code here
...
...
} else {
treSciiss();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (!inpe && (pnast() && cismoc() || pibe != 8) && iswi() == 7 && (pra || doi && jor) && !ar || !phir() || krof() < 6) {
treSciiss();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (u == baltor() && cu && poocen() && acoMored() && ec && muc < 0 || diod && acoMored() && ec && muc < 0) {
if (!he && io) {
if (io) {
return true;
}
if (ertMui()) {
return true;
}
if (!pou) {
return true;
}
if (lidse()) {
return true;
}
}
}
return false;
return (lidse() && !pou && ertMui() || !he) && io || u == baltor() && cu && (poocen() || diod) && acoMored() && ec && muc < 0;
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (!diod && !poocen() && !io || he && !ertMui() || pou || !lidse() || !cu && !io || he && !ertMui() || pou || !lidse() || u != baltor() && !io || he && !ertMui() || pou || !lidse()) {
if (!acoMored() && !io || he && !ertMui() || pou || !lidse()) {
if (!ec && !io || he && !ertMui() || pou || !lidse()) {
if (he && !ertMui() || pou || !lidse()) {
if (!io) {
return false;
}
}
if (muc > 0) {
return false;
}
}
}
}
return true;
Simplify the following messy chain of conditionals:
if ((pami > 3) == true) {
caePubla();
} else if (si == true && (pami > 3) != true) {
cerres();
}
if (co == false && (pami > 3) != true && si != true) {
iarm();
}
if (sa == 1 && (pami > 3) != true && si != true && co != false) {
emmi();
} else if (er == false && (pami > 3) != true && si != true && co != false && sa != 1) {
pruang();
} else if (jeol < es && (pami > 3) != true && si != true && co != false && sa != 1 && er != false) {
dossci();
} else if (saor == true && (pami > 3) != true && si != true && co != false && sa != 1 && er != false && jeol > es) {
ganned();
} else if (ha == true && (pami > 3) != true && si != true && co != false && sa != 1 && er != false && jeol > es && saor != true) {
stima();
}
if (iar == false && (pami > 3) != true && si != true && co != false && sa != 1 && er != false && jeol > es && saor != true && ha != true) {
ralRered();
}
if (aeck >= aeft && (pami > 3) != true && si != true && co != false && sa != 1 && er != false && jeol > es && saor != true && ha != true && iar != false) {
ceia();
} else if ((pami > 3) != true && si != true && co != false && sa != 1 && er != false && jeol > es && saor != true && ha != true && iar != false && aeck <= aeft) {
tostu();
}
{
if (pami > 3) {
caePubla();
}
if (si) {
cerres();
}
if (!co) {
iarm();
}
if (sa == 1) {
emmi();
}
if (!er) {
pruang();
}
if (jeol < es) {
dossci();
}
if (saor) {
ganned();
}
if (ha) {
stima();
}
if (!iar) {
ralRered();
}
if (aeck >= aeft) {
ceia();
}
tostu();
}
Things to double-check in your solution:
== true and == false checks?else, no final if.Related puzzles: