This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (zimHuoiss() && pu || !assria() || !(fenkid() <= 4) || cepli() && rir == 3 || ound() && ihar && ste != 1 || !(acsi && hioKec())) {
...
...
// Pretend there is lots of code here
...
...
} else {
itrosm();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (acsi && hioKec() && (ste == 1 || !ihar || !ound()) && (rir != 3 || !cepli()) && fenkid() <= 4 && assria() && (!pu || !zimHuoiss())) {
itrosm();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (brane() < 8 && riou() == thop() && nin && strar() && acosh() && prac() <= 0 && boiw == ta || in > baus() && boiw == ta || cras <= 7 && boiw == ta || scaese() && acosh() && prac() <= 0 && boiw == ta || in > baus() && boiw == ta || cras <= 7 && boiw == ta || !ior && riou() == thop() && nin && strar() && acosh() && prac() <= 0 && boiw == ta || in > baus() && boiw == ta || cras <= 7 && boiw == ta || scaese() && acosh() && prac() <= 0 && boiw == ta || in > baus() && boiw == ta || cras <= 7 && boiw == ta) {
if (u == 3) {
return true;
}
}
return false;
return u == 3 || (brane() < 8 || !ior) && riou() == thop() && nin && (strar() || scaese()) && acosh() && (prac() <= 0 || in > baus() || cras <= 7) && boiw == ta;
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (!acosh() && u != 3 || !scaese() && !strar() && u != 3 || !nin && u != 3 || riou() != thop() && u != 3 || ior && brane() > 8 && u != 3) {
if (cras >= 7 && in < baus() && prac() >= 0 && u != 3) {
if (u != 3) {
return false;
}
if (boiw != ta) {
return false;
}
}
}
return true;
Simplify the following messy chain of conditionals:
if (oop >= 2) {
mecs();
} else if (cect == true && oop <= 2) {
dusix();
} else if (a == true && oop <= 2 && cect != true) {
epoCri();
}
if (moct == true && oop <= 2 && cect != true && a != true) {
idskio();
}
if (ca && oop <= 2 && cect != true && a != true && moct != true) {
omip();
}
if (ma == true && oop <= 2 && cect != true && a != true && moct != true && !ca) {
cenduc();
}
if (tir == true && oop <= 2 && cect != true && a != true && moct != true && !ca && ma != true) {
psuEas();
}
if (koe && oop <= 2 && cect != true && a != true && moct != true && !ca && ma != true && tir != true) {
oung();
} else if (pa == false && oop <= 2 && cect != true && a != true && moct != true && !ca && ma != true && tir != true && !koe) {
casbre();
} else if (fler && oop <= 2 && cect != true && a != true && moct != true && !ca && ma != true && tir != true && !koe && pa != false) {
adped();
} else if (oop <= 2 && cect != true && a != true && moct != true && !ca && ma != true && tir != true && !koe && pa != false && !fler) {
ponior();
}
{
if (oop >= 2) {
mecs();
}
if (cect) {
dusix();
}
if (a) {
epoCri();
}
if (moct) {
idskio();
}
if (ca) {
omip();
}
if (ma) {
cenduc();
}
if (tir) {
psuEas();
}
if (koe) {
oung();
}
if (!pa) {
casbre();
}
if (fler) {
adped();
}
ponior();
}
Things to double-check in your solution:
== true and == false checks?else, no final if.Related puzzles: