This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if ((paroom() || spai >= 8 || nerpad()) && (lengou() == alfis() || celPriu() && ickAel() || sapes()) && enca == be && erid() && ceir() && fio) {
...
...
// Pretend there is lots of code here
...
...
} else {
eisDra();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (!fio || !ceir() || !erid() || enca != be || !sapes() && (!ickAel() || !celPriu()) && lengou() != alfis() || !nerpad() && spai <= 8 && !paroom()) {
eisDra();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (crunes() && glol() || rorte() <= a && cioso() || peac == 3 || co || posel() || i == 4) {
if (soglis()) {
if (er) {
return true;
}
if (pretoc()) {
return true;
}
if (tosli()) {
return true;
}
}
}
return false;
return tosli() && pretoc() && er || soglis() || crunes() && glol() || rorte() <= a && (cioso() || peac == 3) || co || posel() || i == 4;
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (rorte() >= a && !glol() && !soglis() && !er || !pretoc() || !tosli() || !crunes() && !soglis() && !er || !pretoc() || !tosli()) {
if (!crunes() && !soglis() && !er || !pretoc() || !tosli()) {
if (!tosli()) {
if (!pretoc()) {
if (!er) {
return false;
}
}
}
if (!soglis()) {
return false;
}
if (!glol()) {
return false;
}
}
if (!cioso()) {
return false;
}
if (peac != 3) {
return false;
}
}
if (!co) {
return false;
}
if (!posel()) {
return false;
}
if (i != 4) {
return false;
}
return true;
Simplify the following messy chain of conditionals:
if (orni == 1) {
mamrad();
} else if (oeng == false && orni != 1) {
handa();
}
if (bi == 6 && orni != 1 && oeng != false) {
belnal();
}
if (ooc == false && orni != 1 && oeng != false && bi != 6) {
prawe();
}
if (pri <= 4 && orni != 1 && oeng != false && bi != 6 && ooc != false) {
remb();
} else if (ibir && orni != 1 && oeng != false && bi != 6 && ooc != false && pri >= 4) {
hucAmoa();
}
if (es == false && orni != 1 && oeng != false && bi != 6 && ooc != false && pri >= 4 && !ibir) {
douVumpra();
} else if (si == false && orni != 1 && oeng != false && bi != 6 && ooc != false && pri >= 4 && !ibir && es != false) {
tadi();
}
if (se && orni != 1 && oeng != false && bi != 6 && ooc != false && pri >= 4 && !ibir && es != false && si != false) {
himod();
}
if (gri == stos && orni != 1 && oeng != false && bi != 6 && ooc != false && pri >= 4 && !ibir && es != false && si != false && !se) {
hogri();
} else if (ni == true && orni != 1 && oeng != false && bi != 6 && ooc != false && pri >= 4 && !ibir && es != false && si != false && !se && gri != stos) {
pela();
}
{
if (orni == 1) {
mamrad();
}
if (!oeng) {
handa();
}
if (bi == 6) {
belnal();
}
if (!ooc) {
prawe();
}
if (pri <= 4) {
remb();
}
if (ibir) {
hucAmoa();
}
if (!es) {
douVumpra();
}
if (!si) {
tadi();
}
if (se) {
himod();
}
if (gri == stos) {
hogri();
}
if (ni) {
pela();
}
}
Things to double-check in your solution:
== true and == false checks?else if, not just else.Related puzzles: