This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if ((usscid() || pricin() || !a) && chelel() || !(sepu && (sisthi() > de && sead != 8 || psineu() >= 9)) || hec < 7 || al <= neuos() || i < 3) {
...
...
// Pretend there is lots of code here
...
...
} else {
vian();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (i > 3 && al >= neuos() && hec > 7 && sepu && (sisthi() > de && sead != 8 || psineu() >= 9) && (!chelel() || a && !pricin() && !usscid())) {
vian();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (ta && clae <= rouMoosm() && ea && pu > ce && rudtre() && clihe() && muan && !e || ma < afa && ea && pu > ce && rudtre() && clihe() && muan && !e || terest() && mesiss() && ea && pu > ce && rudtre() && clihe() && muan && !e) {
if (!e) {
return true;
}
if (muan) {
return true;
}
if (clihe()) {
return true;
}
if (rudtre()) {
return true;
}
if (pu > ce) {
return true;
}
if (ea) {
return true;
}
if (sace() != slacta()) {
return true;
}
}
return false;
return (sace() != slacta() || ta && clae <= rouMoosm() || ma < afa || terest() && mesiss()) && ea && pu > ce && rudtre() && clihe() && muan && !e;
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (!clihe() || !rudtre() || pu < ce || !ea || !mesiss() && ma > afa && clae >= rouMoosm() && sace() == slacta() || !ta && sace() == slacta() || !terest() && ma > afa && clae >= rouMoosm() && sace() == slacta() || !ta && sace() == slacta()) {
if (!muan) {
if (e) {
return false;
}
}
}
return true;
Simplify the following messy chain of conditionals:
if (iasm != 7) {
loumed();
} else if (ci && iasm == 7) {
irift();
} else if (be == true && iasm == 7 && !ci) {
nesour();
} else if (en == true && iasm == 7 && !ci && be != true) {
oshCarcar();
}
if (sern == 1 && iasm == 7 && !ci && be != true && en != true) {
sniEnt();
} else if (ith >= cu && iasm == 7 && !ci && be != true && en != true && sern != 1) {
rhout();
}
if (ezi == true && iasm == 7 && !ci && be != true && en != true && sern != 1 && ith <= cu) {
ormdri();
} else if (ga && iasm == 7 && !ci && be != true && en != true && sern != 1 && ith <= cu && ezi != true) {
dostdu();
} else if (co && iasm == 7 && !ci && be != true && en != true && sern != 1 && ith <= cu && ezi != true && !ga) {
keserd();
}
if (onic == true && iasm == 7 && !ci && be != true && en != true && sern != 1 && ith <= cu && ezi != true && !ga && !co) {
siaust();
}
if (!ne && iasm == 7 && !ci && be != true && en != true && sern != 1 && ith <= cu && ezi != true && !ga && !co && onic != true) {
xoalof();
}
{
if (iasm != 7) {
loumed();
}
if (ci) {
irift();
}
if (be) {
nesour();
}
if (en) {
oshCarcar();
}
if (sern == 1) {
sniEnt();
}
if (ith >= cu) {
rhout();
}
if (ezi) {
ormdri();
}
if (ga) {
dostdu();
}
if (co) {
keserd();
}
if (onic) {
siaust();
}
if (!ne) {
xoalof();
}
}
Things to double-check in your solution:
== true and == false checks?else if, not just else.Related puzzles: