This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if ((ik <= 1 || a || !clend() || seece()) && (!snet || arneud() || rost >= 3 || sosha() == iush() && !(!tuem() || na != 0 && hangic()))) {
...
...
// Pretend there is lots of code here
...
...
} else {
riplac();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if ((!tuem() || na != 0 && hangic() || sosha() != iush()) && rost <= 3 && !arneud() && snet || !seece() && clend() && !a && ik >= 1) {
riplac();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (en <= racgil() && iwdo() && ha == 9 || pouOumse() || !is && er <= spi || issIlre() && er <= spi) {
if (ki != 2 && scen) {
if (!mave) {
if (oc) {
return true;
}
}
if (le) {
return true;
}
}
}
return false;
return le && (oc || !mave) || ki != 2 && scen || en <= racgil() && (iwdo() && ha == 9 || pouOumse()) || (!is || issIlre()) && er <= spi;
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (!issIlre() && is && !pouOumse() && ha != 9 && !scen && mave && !oc || !le || ki == 2 && mave && !oc || !le || !iwdo() && !scen && mave && !oc || !le || ki == 2 && mave && !oc || !le || en >= racgil() && !scen && mave && !oc || !le || ki == 2 && mave && !oc || !le) {
if (en >= racgil() && !scen && mave && !oc || !le || ki == 2 && mave && !oc || !le) {
if (!iwdo() && !scen && mave && !oc || !le || ki == 2 && mave && !oc || !le) {
if (ki == 2 && mave && !oc || !le) {
if (!le) {
if (!oc) {
return false;
}
if (mave) {
return false;
}
}
if (!scen) {
return false;
}
}
if (ha != 9) {
return false;
}
}
if (!pouOumse()) {
return false;
}
}
if (er >= spi) {
return false;
}
}
return true;
Simplify the following messy chain of conditionals:
if (gei >= 1) {
epraus();
} else if (e == true && gei <= 1) {
noor();
}
if (ud == true && gei <= 1 && e != true) {
cocGlesdi();
}
if (iu >= susm && gei <= 1 && e != true && ud != true) {
knin();
}
if (pla == true && gei <= 1 && e != true && ud != true && iu <= susm) {
trirk();
}
if (snio && gei <= 1 && e != true && ud != true && iu <= susm && pla != true) {
stoAswhi();
}
if (nin == true && gei <= 1 && e != true && ud != true && iu <= susm && pla != true && !snio) {
hakcoi();
}
if (de < 9 && gei <= 1 && e != true && ud != true && iu <= susm && pla != true && !snio && nin != true) {
atha();
} else if (omal == false && gei <= 1 && e != true && ud != true && iu <= susm && pla != true && !snio && nin != true && de > 9) {
sischu();
} else if (ec < oe && gei <= 1 && e != true && ud != true && iu <= susm && pla != true && !snio && nin != true && de > 9 && omal != false) {
tioc();
} else if (gei <= 1 && e != true && ud != true && iu <= susm && pla != true && !snio && nin != true && de > 9 && omal != false && ec > oe) {
oithes();
}
{
if (gei >= 1) {
epraus();
}
if (e) {
noor();
}
if (ud) {
cocGlesdi();
}
if (iu >= susm) {
knin();
}
if (pla) {
trirk();
}
if (snio) {
stoAswhi();
}
if (nin) {
hakcoi();
}
if (de < 9) {
atha();
}
if (!omal) {
sischu();
}
if (ec < oe) {
tioc();
}
oithes();
}
Things to double-check in your solution:
== true and == false checks?else, no final if.Related puzzles: