This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (!(mo == 9) && snon && toden() || (!ous || fedce() > shir && wil && posssa() == 6 && apent() && dant) && rac && !(cas <= vor)) {
...
...
// Pretend there is lots of code here
...
...
} else {
scren();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if ((cas <= vor || !rac || (!dant || !apent() || posssa() != 6 || !wil || fedce() < shir) && ous) && (!toden() || !snon || mo == 9)) {
scren();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (!lu) {
if (cantal() && epess() || triw > 7 || whis() && epess() || triw > 7) {
if (usspou() || tessos()) {
if (!fi) {
return true;
}
if (ceng >= ota) {
return true;
}
if (anvo) {
return true;
}
}
if (cocHeu()) {
return true;
}
if (dicda()) {
return true;
}
}
}
return false;
return dicda() && cocHeu() && (anvo && ceng >= ota && !fi || usspou() || tessos()) || (cantal() || whis()) && (epess() || triw > 7) || !lu;
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (!whis() && !cantal() && !tessos() && !usspou() && fi || ceng <= ota || !anvo || !cocHeu() || !dicda()) {
if (!cocHeu() || !dicda()) {
if (!anvo) {
if (ceng <= ota) {
if (fi) {
return false;
}
}
}
if (!usspou()) {
return false;
}
if (!tessos()) {
return false;
}
}
if (!epess()) {
return false;
}
if (triw < 7) {
return false;
}
}
if (lu) {
return false;
}
return true;
Simplify the following messy chain of conditionals:
if (rul > 8) {
teonce();
} else if (ef == true && rul < 8) {
cema();
}
if (si == false && rul < 8 && ef != true) {
toril();
} else if (id == true && rul < 8 && ef != true && si != false) {
prast();
}
if (psin == false && rul < 8 && ef != true && si != false && id != true) {
fliHohi();
} else if (pra == 0 && rul < 8 && ef != true && si != false && id != true && psin != false) {
grisge();
} else if (pe && rul < 8 && ef != true && si != false && id != true && psin != false && pra != 0) {
idsa();
} else if (ti && rul < 8 && ef != true && si != false && id != true && psin != false && pra != 0 && !pe) {
psond();
}
if (elo == false && rul < 8 && ef != true && si != false && id != true && psin != false && pra != 0 && !pe && !ti) {
ethded();
} else if (bres > 6 && rul < 8 && ef != true && si != false && id != true && psin != false && pra != 0 && !pe && !ti && elo != false) {
ceao();
}
if (rul < 8 && ef != true && si != false && id != true && psin != false && pra != 0 && !pe && !ti && elo != false && bres < 6) {
cheore();
}
{
if (rul > 8) {
teonce();
}
if (ef) {
cema();
}
if (!si) {
toril();
}
if (id) {
prast();
}
if (!psin) {
fliHohi();
}
if (pra == 0) {
grisge();
}
if (pe) {
idsa();
}
if (ti) {
psond();
}
if (!elo) {
ethded();
}
if (bres > 6) {
ceao();
}
cheore();
}
Things to double-check in your solution:
== true and == false checks?else, no final if.Related puzzles: