This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (cin == aess || !(ar == 2) && tioClatce() || la || fo <= 5 || (sa || !spen() && dril > 3) && (brun || bohu()) || !eson()) {
...
...
// Pretend there is lots of code here
...
...
} else {
enras();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (eson() && (!bohu() && !brun || (dril < 3 || spen()) && !sa) && fo >= 5 && !la && (!tioClatce() || ar == 2) && cin != aess) {
enras();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (vebrec() && tiop() && hias == 7 && refic() >= ce || !grap && grori() == 0 || !i && grori() == 0 || fla == 9 && hias == 7 && refic() >= ce || !grap && grori() == 0 || !i && grori() == 0 || !ci && hias == 7 && refic() >= ce || !grap && grori() == 0 || !i && grori() == 0 || paiw != 9 && tiop() && hias == 7 && refic() >= ce || !grap && grori() == 0 || !i && grori() == 0 || fla == 9 && hias == 7 && refic() >= ce || !grap && grori() == 0 || !i && grori() == 0 || !ci && hias == 7 && refic() >= ce || !grap && grori() == 0 || !i && grori() == 0) {
if (wass > 2) {
if (qedil()) {
return true;
}
}
}
return false;
return qedil() || wass > 2 || (vebrec() || paiw != 9) && (tiop() || fla == 9 || !ci) && (hias == 7 && refic() >= ce || (!grap || !i) && grori() == 0);
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (ci && fla != 9 && !tiop() && wass < 2 && !qedil() || paiw == 9 && !vebrec() && wass < 2 && !qedil()) {
if (i && grap && refic() <= ce && wass < 2 && !qedil() || hias != 7 && wass < 2 && !qedil()) {
if (hias != 7 && wass < 2 && !qedil()) {
if (!qedil()) {
return false;
}
if (wass < 2) {
return false;
}
if (refic() <= ce) {
return false;
}
}
if (grori() != 0) {
return false;
}
}
}
return true;
Simplify the following messy chain of conditionals:
if (oc == true) {
vecAmcasm();
}
if (niru < 8 && oc != true) {
decso();
}
if (ur == cer && oc != true && niru > 8) {
viormi();
} else if (ti == true && oc != true && niru > 8 && ur != cer) {
phed();
} else if (fi > 4 && oc != true && niru > 8 && ur != cer && ti != true) {
splooh();
} else if (kint == true && oc != true && niru > 8 && ur != cer && ti != true && fi < 4) {
oxtia();
}
if (pios >= 5 && oc != true && niru > 8 && ur != cer && ti != true && fi < 4 && kint != true) {
thrint();
} else if (odi == false && oc != true && niru > 8 && ur != cer && ti != true && fi < 4 && kint != true && pios <= 5) {
neco();
} else if ((od != 1) == true && oc != true && niru > 8 && ur != cer && ti != true && fi < 4 && kint != true && pios <= 5 && odi != false) {
snacha();
} else if (bem == true && oc != true && niru > 8 && ur != cer && ti != true && fi < 4 && kint != true && pios <= 5 && odi != false && (od != 1) != true) {
irche();
} else if (oc != true && niru > 8 && ur != cer && ti != true && fi < 4 && kint != true && pios <= 5 && odi != false && (od != 1) != true && bem != true) {
elir();
}
{
if (oc) {
vecAmcasm();
}
if (niru < 8) {
decso();
}
if (ur == cer) {
viormi();
}
if (ti) {
phed();
}
if (fi > 4) {
splooh();
}
if (kint) {
oxtia();
}
if (pios >= 5) {
thrint();
}
if (!odi) {
neco();
}
if (od != 1) {
snacha();
}
if (bem) {
irche();
}
elir();
}
Things to double-check in your solution:
== true and == false checks?else, no final if.Related puzzles: