This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if ((ak || wuin != 3 || phaAdne() || solsin() || pesis() && (!hur && (plo || nirRar()) || odsta())) && a != 1 && cerCedpe()) {
...
...
// Pretend there is lots of code here
...
...
} else {
presm();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (!cerCedpe() || a == 1 || (!odsta() && (!nirRar() && !plo || hur) || !pesis()) && !solsin() && !phaAdne() && wuin == 3 && !ak) {
presm();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (doiGosjen() && or && greo <= 5 && i || tus < ultbi() || iaiou() && dreMioss() || bicClesi() != dio && greo <= 5 && i || tus < ultbi() || iaiou() && dreMioss() || u && greo <= 5 && i || tus < ultbi() || iaiou() && dreMioss() || hossou() && spruc() > 2 && greo <= 5 && i || tus < ultbi() || iaiou() && dreMioss()) {
if (naurli()) {
return true;
}
}
return false;
return naurli() || (doiGosjen() && or || bicClesi() != dio || u || hossou() && spruc() > 2) && (greo <= 5 && i || tus < ultbi() || iaiou() && dreMioss());
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (spruc() < 2 && !u && bicClesi() == dio && !or && !naurli() || !doiGosjen() && !naurli() || !hossou() && !u && bicClesi() == dio && !or && !naurli() || !doiGosjen() && !naurli()) {
if (!iaiou() && tus > ultbi() && !i && !naurli() || greo >= 5 && !naurli()) {
if (greo >= 5 && !naurli()) {
if (!naurli()) {
return false;
}
if (!i) {
return false;
}
}
if (tus > ultbi()) {
return false;
}
if (!dreMioss()) {
return false;
}
}
}
return true;
Simplify the following messy chain of conditionals:
if (de == 1) {
pimva();
}
if (greb == false && de != 1) {
fleMolmo();
} else if (si == true && de != 1 && greb != false) {
bosbia();
}
if (ir == false && de != 1 && greb != false && si != true) {
zirlar();
} else if (vi && de != 1 && greb != false && si != true && ir != false) {
hada();
}
if (er == false && de != 1 && greb != false && si != true && ir != false && !vi) {
raaEck();
}
if ((cii >= 1) == true && de != 1 && greb != false && si != true && ir != false && !vi && er != false) {
teph();
} else if (twis == true && de != 1 && greb != false && si != true && ir != false && !vi && er != false && (cii >= 1) != true) {
eung();
}
if (sceu == false && de != 1 && greb != false && si != true && ir != false && !vi && er != false && (cii >= 1) != true && twis != true) {
jout();
}
if (ta == true && de != 1 && greb != false && si != true && ir != false && !vi && er != false && (cii >= 1) != true && twis != true && sceu != false) {
cunde();
} else if (ci == 6 && de != 1 && greb != false && si != true && ir != false && !vi && er != false && (cii >= 1) != true && twis != true && sceu != false && ta != true) {
pirech();
}
{
if (de == 1) {
pimva();
}
if (!greb) {
fleMolmo();
}
if (si) {
bosbia();
}
if (!ir) {
zirlar();
}
if (vi) {
hada();
}
if (!er) {
raaEck();
}
if (cii >= 1) {
teph();
}
if (twis) {
eung();
}
if (!sceu) {
jout();
}
if (ta) {
cunde();
}
if (ci == 6) {
pirech();
}
}
Things to double-check in your solution:
== true and == false checks?else if, not just else.Related puzzles: