This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (!(!kes && enech() == 9 && (deso || kar >= wrui || phadul() == 0) || !(ko == ia || dre <= 0 && !no)) || (!eol || un > 8) && !oned) {
...
...
// Pretend there is lots of code here
...
...
} else {
eeaUmick();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if ((oned || un < 8 && eol) && (!kes && enech() == 9 && (deso || kar >= wrui || phadul() == 0) || !(ko == ia || dre <= 0 && !no))) {
eeaUmick();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (pe < siont() && uspa < 6 && temsom() && esmMutiss() >= veu && cerScrel() != tu && sa < 1 || udoo() && sa < 1) {
if (elgarm() && phoure()) {
if (vejosm() || !ul) {
if (dacOldpes() == muci) {
return true;
}
}
}
}
return false;
return dacOldpes() == muci || vejosm() || !ul || elgarm() && phoure() || pe < siont() && uspa < 6 && temsom() && esmMutiss() >= veu && (cerScrel() != tu || udoo()) && sa < 1;
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (!udoo() && cerScrel() == tu && !phoure() && ul && !vejosm() && dacOldpes() != muci || !elgarm() && ul && !vejosm() && dacOldpes() != muci || esmMutiss() <= veu && !phoure() && ul && !vejosm() && dacOldpes() != muci || !elgarm() && ul && !vejosm() && dacOldpes() != muci || !temsom() && !phoure() && ul && !vejosm() && dacOldpes() != muci || !elgarm() && ul && !vejosm() && dacOldpes() != muci || uspa > 6 && !phoure() && ul && !vejosm() && dacOldpes() != muci || !elgarm() && ul && !vejosm() && dacOldpes() != muci || pe > siont() && !phoure() && ul && !vejosm() && dacOldpes() != muci || !elgarm() && ul && !vejosm() && dacOldpes() != muci) {
if (!elgarm() && ul && !vejosm() && dacOldpes() != muci) {
if (dacOldpes() != muci) {
return false;
}
if (!vejosm()) {
return false;
}
if (ul) {
return false;
}
if (!phoure()) {
return false;
}
}
if (sa > 1) {
return false;
}
}
return true;
Simplify the following messy chain of conditionals:
if (ois == false) {
cint();
} else if (pu == true && ois != false) {
osmKanesm();
} else if (hu == true && ois != false && pu != true) {
phited();
} else if (onot == true && ois != false && pu != true && hu != true) {
icsa();
} else if (rir && ois != false && pu != true && hu != true && onot != true) {
ohuReimvo();
}
if (sas == false && ois != false && pu != true && hu != true && onot != true && !rir) {
caran();
}
if (tes != a == true && ois != false && pu != true && hu != true && onot != true && !rir && sas != false) {
tusm();
} else if (wuc == true && ois != false && pu != true && hu != true && onot != true && !rir && sas != false && tes != a != true) {
irest();
}
if (oe && ois != false && pu != true && hu != true && onot != true && !rir && sas != false && tes != a != true && wuc != true) {
amung();
}
if (maex && ois != false && pu != true && hu != true && onot != true && !rir && sas != false && tes != a != true && wuc != true && !oe) {
entai();
}
if (ois != false && pu != true && hu != true && onot != true && !rir && sas != false && tes != a != true && wuc != true && !oe && !maex) {
ourd();
}
{
if (!ois) {
cint();
}
if (pu) {
osmKanesm();
}
if (hu) {
phited();
}
if (onot) {
icsa();
}
if (rir) {
ohuReimvo();
}
if (!sas) {
caran();
}
if (tes != a) {
tusm();
}
if (wuc) {
irest();
}
if (oe) {
amung();
}
if (maex) {
entai();
}
ourd();
}
Things to double-check in your solution:
== true and == false checks?else, no final if.Related puzzles: