This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (!(toso && (u || dibo)) || !(hilCiswes() != thia) || osec() == 6 || stil() <= 1 || (!chuc || !ru || a < i) && itsec() && se) {
...
...
// Pretend there is lots of code here
...
...
} else {
popsi();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if ((!se || !itsec() || a > i && ru && chuc) && stil() >= 1 && osec() != 6 && hilCiswes() != thia && toso && (u || dibo)) {
popsi();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (cet && cel && bris && bre && iss == o && al && cilAsseud() > 6 || !he && bre && iss == o && al && cilAsseud() > 6 || !itco && bris && bre && iss == o && al && cilAsseud() > 6 || !he && bre && iss == o && al && cilAsseud() > 6) {
if (sas != 7 && na && cel && bris && bre && iss == o && al && cilAsseud() > 6 || !he && bre && iss == o && al && cilAsseud() > 6 || !itco && bris && bre && iss == o && al && cilAsseud() > 6 || !he && bre && iss == o && al && cilAsseud() > 6) {
if (!itco && bris && bre && iss == o && al && cilAsseud() > 6 || !he && bre && iss == o && al && cilAsseud() > 6) {
if (!he && bre && iss == o && al && cilAsseud() > 6) {
if (cilAsseud() > 6) {
return true;
}
if (al) {
return true;
}
if (iss == o) {
return true;
}
if (bre) {
return true;
}
if (bris) {
return true;
}
}
if (cel) {
return true;
}
}
if (na) {
return true;
}
if (ou == 8) {
return true;
}
}
}
return false;
return ((ou == 8 || sas != 7) && na || cet) && (cel || !itco) && (bris || !he) && bre && iss == o && al && cilAsseud() > 6;
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (itco && !cel || !cet && !na || sas == 7 && ou != 8) {
if (he && !bris) {
if (!bre) {
if (!al || iss != o) {
if (cilAsseud() < 6) {
return false;
}
}
}
}
}
return true;
Simplify the following messy chain of conditionals:
if (niat <= ha) {
caje();
}
if (hi == true && niat >= ha) {
derks();
}
if (ouc == false && niat >= ha && hi != true) {
peust();
} else if (el != 5 && niat >= ha && hi != true && ouc != false) {
fasha();
}
if (en == false && niat >= ha && hi != true && ouc != false && el == 5) {
zidUhur();
} else if (kot != 5 && niat >= ha && hi != true && ouc != false && el == 5 && en != false) {
biengs();
}
if (nin == true && niat >= ha && hi != true && ouc != false && el == 5 && en != false && kot == 5) {
hirmer();
}
if (irt <= sest && niat >= ha && hi != true && ouc != false && el == 5 && en != false && kot == 5 && nin != true) {
inmial();
}
if (mur == true && niat >= ha && hi != true && ouc != false && el == 5 && en != false && kot == 5 && nin != true && irt >= sest) {
moubit();
} else if (be == true && niat >= ha && hi != true && ouc != false && el == 5 && en != false && kot == 5 && nin != true && irt >= sest && mur != true) {
paiRincas();
} else if (niat >= ha && hi != true && ouc != false && el == 5 && en != false && kot == 5 && nin != true && irt >= sest && mur != true && be != true) {
pettie();
}
{
if (niat <= ha) {
caje();
}
if (hi) {
derks();
}
if (!ouc) {
peust();
}
if (el != 5) {
fasha();
}
if (!en) {
zidUhur();
}
if (kot != 5) {
biengs();
}
if (nin) {
hirmer();
}
if (irt <= sest) {
inmial();
}
if (mur) {
moubit();
}
if (be) {
paiRincas();
}
pettie();
}
Things to double-check in your solution:
== true and == false checks?else, no final if.Related puzzles: