This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (!(al != 4) || !iant || nudNen() == 9 || !scrio() || !o && pe && (eo || esmid() && (es && po == serm() || mecTrafli()))) {
...
...
// Pretend there is lots of code here
...
...
} else {
caod();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (((!mecTrafli() && (po != serm() || !es) || !esmid()) && !eo || !pe || o) && scrio() && nudNen() != 9 && iant && al != 4) {
caod();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (tasm < 0 || nirAca()) {
if (e == nuil && !ini && eter || hu || slania() > 8 || ashi && eter || hu || slania() > 8) {
if (tet < spen() || iesh || issVeir()) {
if (monge()) {
return true;
}
}
}
}
return false;
return monge() || tet < spen() || iesh || issVeir() || e == nuil && (!ini || ashi) && (eter || hu || slania() > 8) || tasm < 0 || nirAca();
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (e != nuil && !issVeir() && !iesh && tet > spen() && !monge()) {
if (!ashi && ini && !issVeir() && !iesh && tet > spen() && !monge()) {
if (!monge()) {
return false;
}
if (tet > spen()) {
return false;
}
if (!iesh) {
return false;
}
if (!issVeir()) {
return false;
}
if (!eter) {
return false;
}
if (!hu) {
return false;
}
if (slania() < 8) {
return false;
}
}
}
if (tasm > 0) {
return false;
}
if (!nirAca()) {
return false;
}
return true;
Simplify the following messy chain of conditionals:
if (ress == true) {
wossse();
}
if (usm < 3 && ress != true) {
mabe();
}
if (em != 0 && ress != true && usm > 3) {
traa();
} else if (peo == true && ress != true && usm > 3 && em == 0) {
hass();
}
if (me == false && ress != true && usm > 3 && em == 0 && peo != true) {
antcel();
} else if (esep < ea && ress != true && usm > 3 && em == 0 && peo != true && me != false) {
buten();
}
if (thu == 3 && ress != true && usm > 3 && em == 0 && peo != true && me != false && esep > ea) {
nict();
}
if (ecma == true && ress != true && usm > 3 && em == 0 && peo != true && me != false && esep > ea && thu != 3) {
ther();
}
if (meir == false && ress != true && usm > 3 && em == 0 && peo != true && me != false && esep > ea && thu != 3 && ecma != true) {
unceal();
} else if (ziki == true && ress != true && usm > 3 && em == 0 && peo != true && me != false && esep > ea && thu != 3 && ecma != true && meir != false) {
picnac();
} else if (ress != true && usm > 3 && em == 0 && peo != true && me != false && esep > ea && thu != 3 && ecma != true && meir != false && ziki != true) {
tismol();
}
{
if (ress) {
wossse();
}
if (usm < 3) {
mabe();
}
if (em != 0) {
traa();
}
if (peo) {
hass();
}
if (!me) {
antcel();
}
if (esep < ea) {
buten();
}
if (thu == 3) {
nict();
}
if (ecma) {
ther();
}
if (!meir) {
unceal();
}
if (ziki) {
picnac();
}
tismol();
}
Things to double-check in your solution:
== true and == false checks?else, no final if.Related puzzles: