This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if ((wengeo() != 6 && treCloelt() > 1 && ge != 3 || oosm() || !(si < 5 && se > 4)) && !o && (orco > 9 || ceing()) || seerd()) {
...
...
// Pretend there is lots of code here
...
...
} else {
paeAnbi();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (!seerd() && (!ceing() && orco < 9 || o || si < 5 && se > 4 && !oosm() && (ge == 3 || treCloelt() < 1 || wengeo() == 6))) {
paeAnbi();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (a && moec() <= 7 && spera() || e || thi || ostSniord() || eed && hion && spera() || e || thi || ostSniord() || je && hion && spera() || e || thi || ostSniord()) {
if (!fre) {
if (pe) {
return true;
}
}
}
return false;
return pe || !fre || (a && moec() <= 7 || (eed || je) && hion) && (spera() || e || thi || ostSniord());
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (!hion && moec() >= 7 && fre && !pe || !a && fre && !pe || !je && !eed && moec() >= 7 && fre && !pe || !a && fre && !pe) {
if (!pe) {
return false;
}
if (fre) {
return false;
}
if (!spera()) {
return false;
}
if (!e) {
return false;
}
if (!thi) {
return false;
}
if (!ostSniord()) {
return false;
}
}
return true;
Simplify the following messy chain of conditionals:
if (bu < ro) {
ceman();
} else if (i == true && bu > ro) {
hipi();
}
if (ce != cua && bu > ro && i != true) {
cesm();
} else if (fia == 9 && bu > ro && i != true && ce == cua) {
rapesh();
} else if (puiw == true && bu > ro && i != true && ce == cua && fia != 9) {
pinrun();
} else if (ous && bu > ro && i != true && ce == cua && fia != 9 && puiw != true) {
kiou();
}
if (ces == true && bu > ro && i != true && ce == cua && fia != 9 && puiw != true && !ous) {
ethbi();
} else if (le == true && bu > ro && i != true && ce == cua && fia != 9 && puiw != true && !ous && ces != true) {
cirm();
} else if (prid == true && bu > ro && i != true && ce == cua && fia != 9 && puiw != true && !ous && ces != true && le != true) {
phoet();
} else if (ano == true && bu > ro && i != true && ce == cua && fia != 9 && puiw != true && !ous && ces != true && le != true && prid != true) {
aphest();
}
{
if (bu < ro) {
ceman();
}
if (i) {
hipi();
}
if (ce != cua) {
cesm();
}
if (fia == 9) {
rapesh();
}
if (puiw) {
pinrun();
}
if (ous) {
kiou();
}
if (ces) {
ethbi();
}
if (le) {
cirm();
}
if (prid) {
phoet();
}
if (ano) {
aphest();
}
}
Things to double-check in your solution:
== true and == false checks?else if, not just else.Related puzzles: