This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (leri < oprid() || !rac || alge || (suaw == axeas() && viftal() || aarSkidel()) && we && e && ipolt() && sasm) {
...
...
// Pretend there is lots of code here
...
...
} else {
treang();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if ((!sasm || !ipolt() || !e || !we || !aarSkidel() && (!viftal() || suaw != axeas())) && !alge && rac && leri > oprid()) {
treang();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (!acco && uphe() || dusmu() || idteou() <= 9 || a == 8 && spop) {
if (ne && alno() && lecbo() <= rost) {
if (iaant() && lecbo() <= rost) {
if (lecbo() <= rost) {
return true;
}
if (misi) {
return true;
}
}
}
}
return false;
return (misi || iaant() || ne && alno()) && lecbo() <= rost || !acco && (uphe() || dusmu() || idteou() <= 9 || a == 8 && spop);
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (acco && lecbo() >= rost || !alno() && !iaant() && !misi || !ne && !iaant() && !misi) {
if (a != 8 && idteou() >= 9 && !dusmu() && !uphe() && lecbo() >= rost || !alno() && !iaant() && !misi || !ne && !iaant() && !misi) {
if (!alno() && !iaant() && !misi || !ne && !iaant() && !misi) {
if (lecbo() >= rost) {
return false;
}
}
if (!uphe()) {
return false;
}
if (!dusmu()) {
return false;
}
if (idteou() >= 9) {
return false;
}
if (!spop) {
return false;
}
}
}
return true;
Simplify the following messy chain of conditionals:
if (oss == true) {
shopo();
}
if (cial == false && oss != true) {
sesSpesix();
}
if (druc == false && oss != true && cial != false) {
sqish();
} else if (!pirt && oss != true && cial != false && druc != false) {
lorm();
} else if (be == true && oss != true && cial != false && druc != false && pirt) {
eotPlos();
} else if ((ocec == 8) == true && oss != true && cial != false && druc != false && pirt && be != true) {
ucass();
}
if (si == su && oss != true && cial != false && druc != false && pirt && be != true && (ocec == 8) != true) {
rescul();
} else if (ad != afla && oss != true && cial != false && druc != false && pirt && be != true && (ocec == 8) != true && si != su) {
bilCoen();
}
if (acir == false && oss != true && cial != false && druc != false && pirt && be != true && (ocec == 8) != true && si != su && ad == afla) {
cais();
}
if (hana == true && oss != true && cial != false && druc != false && pirt && be != true && (ocec == 8) != true && si != su && ad == afla && acir != false) {
iang();
}
{
if (oss) {
shopo();
}
if (!cial) {
sesSpesix();
}
if (!druc) {
sqish();
}
if (!pirt) {
lorm();
}
if (be) {
eotPlos();
}
if (ocec == 8) {
ucass();
}
if (si == su) {
rescul();
}
if (ad != afla) {
bilCoen();
}
if (!acir) {
cais();
}
if (hana) {
iang();
}
}
Things to double-check in your solution:
== true and == false checks?else if, not just else.Related puzzles: