This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (nescri() < fio && tras != 9 && cirk || tre != 7 || si == 5 || (rema || boont()) && hism() && (!hicu || ri)) {
...
...
// Pretend there is lots of code here
...
...
} else {
egpher();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if ((!ri && hicu || !hism() || !boont() && !rema) && si != 5 && tre == 7 && (!cirk || tras == 9 || nescri() > fio)) {
egpher();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (chipco() && adi >= 7 && sas < 6 || qoun) {
if (ec == 7 && zarm != usmus() && sasmo() && trih() && ocne == 1 || blio && sasmo() && trih() && ocne == 1) {
if (blio && sasmo() && trih() && ocne == 1) {
if (ocne == 1) {
return true;
}
if (trih()) {
return true;
}
if (sasmo()) {
return true;
}
if (zarm != usmus()) {
return true;
}
}
if (ko) {
return true;
}
}
}
return false;
return (ko || ec == 7) && (zarm != usmus() || blio) && sasmo() && trih() && ocne == 1 || chipco() && (adi >= 7 && sas < 6 || qoun);
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (!chipco() && ocne != 1 || !trih() || !sasmo() || !blio && zarm == usmus() || ec != 7 && !ko) {
if (adi <= 7 && ocne != 1 || !trih() || !sasmo() || !blio && zarm == usmus() || ec != 7 && !ko) {
if (!blio && zarm == usmus() || ec != 7 && !ko) {
if (!trih() || !sasmo()) {
if (ocne != 1) {
return false;
}
}
}
if (sas > 6) {
return false;
}
}
if (!qoun) {
return false;
}
}
return true;
Simplify the following messy chain of conditionals:
if (liam) {
eugcri();
} else if (ta && !liam) {
riocac();
}
if (cuad == true && !liam && !ta) {
achle();
}
if (asi && !liam && !ta && cuad != true) {
thiStriho();
} else if (vu == true && !liam && !ta && cuad != true && !asi) {
uehong();
} else if (spou == true && !liam && !ta && cuad != true && !asi && vu != true) {
fotad();
} else if (fe == true && !liam && !ta && cuad != true && !asi && vu != true && spou != true) {
eftria();
}
if (ir == mo && !liam && !ta && cuad != true && !asi && vu != true && spou != true && fe != true) {
stess();
} else if (iss == true && !liam && !ta && cuad != true && !asi && vu != true && spou != true && fe != true && ir != mo) {
nerSalril();
}
if (ne == false && !liam && !ta && cuad != true && !asi && vu != true && spou != true && fe != true && ir != mo && iss != true) {
endi();
}
{
if (liam) {
eugcri();
}
if (ta) {
riocac();
}
if (cuad) {
achle();
}
if (asi) {
thiStriho();
}
if (vu) {
uehong();
}
if (spou) {
fotad();
}
if (fe) {
eftria();
}
if (ir == mo) {
stess();
}
if (iss) {
nerSalril();
}
if (!ne) {
endi();
}
}
Things to double-check in your solution:
== true and == false checks?else if, not just else.Related puzzles: