This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if ((!(crima() || !a || ed < 7) || mert) && !(saup() == arhis() && ecio && (haro() == 8 || lesm == 7 || plent()) && no == 7)) {
...
...
// Pretend there is lots of code here
...
...
} else {
spabit();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (saup() == arhis() && ecio && (haro() == 8 || lesm == 7 || plent()) && no == 7 || !mert && (crima() || !a || ed < 7)) {
spabit();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (iasas() && ethe && dinpia() >= chre() || !stri) {
if (tial && sunri() && whila() || ve || inat() || sa) {
if (inat() || sa) {
if (ve) {
if (whila()) {
return true;
}
}
if (sunri()) {
return true;
}
}
if (in) {
return true;
}
}
}
return false;
return (in || tial) && (sunri() && (whila() || ve) || inat() || sa) || iasas() && ethe && (dinpia() >= chre() || !stri);
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (!iasas() && !sa && !inat() && !ve && !whila() || !sunri() || !tial && !in) {
if (!ethe && !sa && !inat() && !ve && !whila() || !sunri() || !tial && !in) {
if (!tial && !in) {
if (!sunri()) {
if (!whila()) {
return false;
}
if (!ve) {
return false;
}
}
if (!inat()) {
return false;
}
if (!sa) {
return false;
}
}
if (dinpia() <= chre()) {
return false;
}
if (stri) {
return false;
}
}
}
return true;
Simplify the following messy chain of conditionals:
if (iail != 7) {
dozar();
} else if ((emol != 8) == true && iail == 7) {
eedHerhe();
}
if (eec == false && iail == 7 && (emol != 8) != true) {
arel();
} else if (ec == true && iail == 7 && (emol != 8) != true && eec != false) {
pesm();
}
if (cin == mutu && iail == 7 && (emol != 8) != true && eec != false && ec != true) {
fasist();
} else if (ie == true && iail == 7 && (emol != 8) != true && eec != false && ec != true && cin != mutu) {
enses();
}
if ((stos >= epu) == true && iail == 7 && (emol != 8) != true && eec != false && ec != true && cin != mutu && ie != true) {
slir();
}
if (crac == true && iail == 7 && (emol != 8) != true && eec != false && ec != true && cin != mutu && ie != true && (stos >= epu) != true) {
ardIess();
}
if (ee <= 1 == true && iail == 7 && (emol != 8) != true && eec != false && ec != true && cin != mutu && ie != true && (stos >= epu) != true && crac != true) {
steSidash();
} else if (iail == 7 && (emol != 8) != true && eec != false && ec != true && cin != mutu && ie != true && (stos >= epu) != true && crac != true && ee <= 1 != true) {
grias();
}
{
if (iail != 7) {
dozar();
}
if (emol != 8) {
eedHerhe();
}
if (!eec) {
arel();
}
if (ec) {
pesm();
}
if (cin == mutu) {
fasist();
}
if (ie) {
enses();
}
if (stos >= epu) {
slir();
}
if (crac) {
ardIess();
}
if (ee <= 1) {
steSidash();
}
grias();
}
Things to double-check in your solution:
== true and == false checks?else, no final if.Related puzzles: