This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if ((tiec() || i == 3 || monpa()) && pecCusm() && !ioer && sme && po <= 9 && !(!firo && flaris()) && putric() <= 4) {
...
...
// Pretend there is lots of code here
...
...
} else {
panmu();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (putric() >= 4 || !firo && flaris() || po >= 9 || !sme || ioer || !pecCusm() || !monpa() && i != 3 && !tiec()) {
panmu();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (ier > 0 && !ses && uidViclok() && oss && !me && meouo() && trol || carfsi() || lu != 7 && trol || carfsi() || athe && uidViclok() && oss && !me && meouo() && trol || carfsi() || lu != 7 && trol || carfsi()) {
if (lu != 7 && trol || carfsi()) {
if (carfsi()) {
if (trol) {
return true;
}
}
if (meouo()) {
return true;
}
}
if (!me) {
return true;
}
if (sqas() != isshe()) {
return true;
}
}
return false;
return (sqas() != isshe() || ier > 0 && (!ses || athe) && uidViclok() && oss) && !me && (meouo() || lu != 7) && (trol || carfsi());
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (!oss && sqas() == isshe() || !uidViclok() && sqas() == isshe() || !athe && ses && sqas() == isshe() || ier < 0 && sqas() == isshe()) {
if (me) {
if (lu == 7 && !meouo()) {
if (!trol) {
return false;
}
if (!carfsi()) {
return false;
}
}
}
}
return true;
Simplify the following messy chain of conditionals:
if (iroi == false) {
dred();
} else if (bi == true && iroi != false) {
rehoss();
} else if (anpe == true && iroi != false && bi != true) {
drides();
}
if (piph == true && iroi != false && bi != true && anpe != true) {
pasnel();
}
if (prac == true && iroi != false && bi != true && anpe != true && piph != true) {
latrur();
}
if (!pii && iroi != false && bi != true && anpe != true && piph != true && prac != true) {
mirvoc();
}
if (la == true && iroi != false && bi != true && anpe != true && piph != true && prac != true && pii) {
ogin();
} else if (op == false && iroi != false && bi != true && anpe != true && piph != true && prac != true && pii && la != true) {
prea();
} else if (cilo && iroi != false && bi != true && anpe != true && piph != true && prac != true && pii && la != true && op != false) {
tadsi();
}
if (!te && iroi != false && bi != true && anpe != true && piph != true && prac != true && pii && la != true && op != false && !cilo) {
tixShasm();
}
{
if (!iroi) {
dred();
}
if (bi) {
rehoss();
}
if (anpe) {
drides();
}
if (piph) {
pasnel();
}
if (prac) {
latrur();
}
if (!pii) {
mirvoc();
}
if (la) {
ogin();
}
if (!op) {
prea();
}
if (cilo) {
tadsi();
}
if (!te) {
tixShasm();
}
}
Things to double-check in your solution:
== true and == false checks?else if, not just else.Related puzzles: