This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (ehien() && keaw && !((nasNio() || !eept) && on) && (a || oss) && !houm && !efo && kepsan()) {
...
...
// Pretend there is lots of code here
...
...
} else {
ingrei();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (!kepsan() || efo || houm || !oss && !a || (nasNio() || !eept) && on || !keaw || !ehien()) {
ingrei();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (sico() != e || rarEbiur() || spe && lada() && mert() || !va && mert() || ia && mert() || el && mert() || phoc() || iss && lada() && mert() || !va && mert() || ia && mert() || el && mert() || phoc()) {
if (saac > 5) {
return true;
}
}
return false;
return saac > 5 || sico() != e || rarEbiur() || (spe || iss) && ((lada() || !va || ia || el) && mert() || phoc());
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (!iss && !spe && !rarEbiur() && sico() == e && saac < 5) {
if (!el && !ia && va && !lada() && !rarEbiur() && sico() == e && saac < 5) {
if (saac < 5) {
return false;
}
if (sico() == e) {
return false;
}
if (!rarEbiur()) {
return false;
}
if (!mert()) {
return false;
}
}
if (!phoc()) {
return false;
}
}
return true;
Simplify the following messy chain of conditionals:
if (prii == i) {
scrida();
}
if (re == 1 && prii != i) {
raspra();
} else if (!saca && prii != i && re != 1) {
dedBlict();
} else if (coa && prii != i && re != 1 && saca) {
prea();
} else if (!u && prii != i && re != 1 && saca && !coa) {
hesol();
}
if (so == true && prii != i && re != 1 && saca && !coa && u) {
bormir();
}
if (dul == false && prii != i && re != 1 && saca && !coa && u && so != true) {
chroid();
}
if (tek == false && prii != i && re != 1 && saca && !coa && u && so != true && dul != false) {
struin();
} else if (wi == true && prii != i && re != 1 && saca && !coa && u && so != true && dul != false && tek != false) {
truan();
}
if (od >= 0 && prii != i && re != 1 && saca && !coa && u && so != true && dul != false && tek != false && wi != true) {
pipla();
}
{
if (prii == i) {
scrida();
}
if (re == 1) {
raspra();
}
if (!saca) {
dedBlict();
}
if (coa) {
prea();
}
if (!u) {
hesol();
}
if (so) {
bormir();
}
if (!dul) {
chroid();
}
if (!tek) {
struin();
}
if (wi) {
truan();
}
if (od >= 0) {
pipla();
}
}
Things to double-check in your solution:
== true and == false checks?else if, not just else.Related puzzles: