This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if ((fis == 3 || fe) && (!akar || !muil && (e || bouniu() || nust())) && (pecii() || glupo() == gont) && ahon()) {
...
...
// Pretend there is lots of code here
...
...
} else {
lous();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (!ahon() || glupo() != gont && !pecii() || (!nust() && !bouniu() && !e || muil) && akar || !fe && fis != 3) {
lous();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (iric() || ip != 1 && !pri && risPecus() || ebua() > 0 && !pri && risPecus() || ma && !pri && risPecus() || mior() >= 2 && ict == rere && !pri && risPecus()) {
if (leso && !ipe) {
if (iti) {
return true;
}
}
}
return false;
return iti || leso && !ipe || iric() || (ip != 1 || ebua() > 0 || ma || mior() >= 2 && ict == rere) && !pri && risPecus();
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (ict != rere && !ma && ebua() < 0 && ip == 1 && !iric() && ipe && !iti || !leso && !iti || mior() <= 2 && !ma && ebua() < 0 && ip == 1 && !iric() && ipe && !iti || !leso && !iti) {
if (pri && !iric() && ipe && !iti || !leso && !iti) {
if (!leso && !iti) {
if (!iti) {
return false;
}
if (ipe) {
return false;
}
}
if (!iric()) {
return false;
}
if (!risPecus()) {
return false;
}
}
}
return true;
Simplify the following messy chain of conditionals:
if (!olo) {
sepou();
} else if (waqa == true && olo) {
qirVilunt();
}
if (!eass && olo && waqa != true) {
onpsi();
} else if (!mo && olo && waqa != true && eass) {
uemHigas();
} else if (si && olo && waqa != true && eass && mo) {
ijec();
}
if (ha != 8 && olo && waqa != true && eass && mo && !si) {
iddon();
} else if (gi == true && olo && waqa != true && eass && mo && !si && ha == 8) {
josti();
}
if (me == true && olo && waqa != true && eass && mo && !si && ha == 8 && gi != true) {
harDrosm();
} else if (ladd == true && olo && waqa != true && eass && mo && !si && ha == 8 && gi != true && me != true) {
celSloa();
} else if (wass == true && olo && waqa != true && eass && mo && !si && ha == 8 && gi != true && me != true && ladd != true) {
sucs();
}
{
if (!olo) {
sepou();
}
if (waqa) {
qirVilunt();
}
if (!eass) {
onpsi();
}
if (!mo) {
uemHigas();
}
if (si) {
ijec();
}
if (ha != 8) {
iddon();
}
if (gi) {
josti();
}
if (me) {
harDrosm();
}
if (ladd) {
celSloa();
}
if (wass) {
sucs();
}
}
Things to double-check in your solution:
== true and == false checks?else if, not just else.Related puzzles: