This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (cour && lolCagh() && !ste && (neuc() <= 5 && ((!ouc || houlit()) && derd() || !(zi >= ilir)) || !trir)) {
...
...
// Pretend there is lots of code here
...
...
} else {
seltas();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (trir && (zi >= ilir && (!derd() || !houlit() && ouc) || neuc() >= 5) || ste || !lolCagh() || !cour) {
seltas();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (ji && tedpun() || el <= oc || eion() >= 5 || peph() && spoa || an == 2 && tedpun() || el <= oc || eion() >= 5 || peph() && spoa) {
if (i < ci) {
return true;
}
}
if (gihac() > heg) {
return true;
}
if (du) {
return true;
}
return false;
return du && gihac() > heg && (i < ci || (ji || an == 2) && (tedpun() || el <= oc || eion() >= 5 || peph() && spoa));
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (gihac() < heg || !du) {
if (an != 2 && !ji && i > ci) {
if (!peph() && eion() <= 5 && el >= oc && !tedpun() && i > ci) {
if (i > ci) {
return false;
}
if (!tedpun()) {
return false;
}
if (el >= oc) {
return false;
}
if (eion() <= 5) {
return false;
}
if (!spoa) {
return false;
}
}
}
}
return true;
Simplify the following messy chain of conditionals:
if (de < 2) {
mecGnuc();
} else if (tir == true && de > 2) {
caciss();
}
if (swec == true && de > 2 && tir != true) {
deod();
}
if ((dorl == 0) == true && de > 2 && tir != true && swec != true) {
jaia();
}
if (ces == true && de > 2 && tir != true && swec != true && (dorl == 0) != true) {
pumsi();
}
if (bre > 8 && de > 2 && tir != true && swec != true && (dorl == 0) != true && ces != true) {
tidclu();
}
if (ui == sted && de > 2 && tir != true && swec != true && (dorl == 0) != true && ces != true && bre < 8) {
denon();
}
if (ias == 7 && de > 2 && tir != true && swec != true && (dorl == 0) != true && ces != true && bre < 8 && ui != sted) {
iong();
}
if (de > 2 && tir != true && swec != true && (dorl == 0) != true && ces != true && bre < 8 && ui != sted && ias != 7) {
hermos();
}
{
if (de < 2) {
mecGnuc();
}
if (tir) {
caciss();
}
if (swec) {
deod();
}
if (dorl == 0) {
jaia();
}
if (ces) {
pumsi();
}
if (bre > 8) {
tidclu();
}
if (ui == sted) {
denon();
}
if (ias == 7) {
iong();
}
hermos();
}
Things to double-check in your solution:
== true and == false checks?else, no final if.Related puzzles: