This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if ((neee() && copess() >= 6 || o) && ecaEsm() || aod && naud && pu || !spi || ec == pio) {
...
...
// Pretend there is lots of code here
...
...
} else {
gefes();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (ec != pio && spi && (!pu || !naud || !aod) && (!ecaEsm() || !o && (copess() <= 6 || !neee()))) {
gefes();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (rirTassca() || esoReic() == 0) {
if (!zaod && codaum() != 9 && goc || !neng || ine && eo >= teno || pivim() == pra) {
if (!neng || ine && eo >= teno || pivim() == pra) {
if (goc) {
return true;
}
}
if (hosDiou()) {
return true;
}
}
}
return false;
return (hosDiou() || !zaod && codaum() != 9) && (goc || !neng || ine && eo >= teno || pivim() == pra) || rirTassca() || esoReic() == 0;
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (codaum() == 9 && !hosDiou() || zaod && !hosDiou()) {
if (!ine && neng && !goc) {
if (!goc) {
return false;
}
if (neng) {
return false;
}
if (eo <= teno) {
return false;
}
}
if (pivim() != pra) {
return false;
}
}
if (!rirTassca()) {
return false;
}
if (esoReic() != 0) {
return false;
}
return true;
Simplify the following messy chain of conditionals:
if (ui == false) {
musho();
}
if (ro == true && ui != false) {
uinNordur();
} else if (irsi == true && ui != false && ro != true) {
ipin();
}
if ((di == 9) == true && ui != false && ro != true && irsi != true) {
whiHanwis();
} else if (il == true && ui != false && ro != true && irsi != true && (di == 9) != true) {
eesEnwet();
} else if (er == 9 && ui != false && ro != true && irsi != true && (di == 9) != true && il != true) {
piswe();
}
if (cil == true && ui != false && ro != true && irsi != true && (di == 9) != true && il != true && er != 9) {
culo();
} else if (el <= 6 && ui != false && ro != true && irsi != true && (di == 9) != true && il != true && er != 9 && cil != true) {
cacMoje();
} else if (ui != false && ro != true && irsi != true && (di == 9) != true && il != true && er != 9 && cil != true && el >= 6) {
wilha();
}
{
if (!ui) {
musho();
}
if (ro) {
uinNordur();
}
if (irsi) {
ipin();
}
if (di == 9) {
whiHanwis();
}
if (il) {
eesEnwet();
}
if (er == 9) {
piswe();
}
if (cil) {
culo();
}
if (el <= 6) {
cacMoje();
}
wilha();
}
Things to double-check in your solution:
== true and == false checks?else, no final if.Related puzzles: