This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (!nanseo() || i || !in || bross() && !gic && apec() == posm || mi || euo == jo || !riad()) {
...
...
// Pretend there is lots of code here
...
...
} else {
flisim();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (riad() && euo != jo && !mi && (apec() != posm || gic || !bross()) && in && !i && nanseo()) {
flisim();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (!sio && tru && cip == 5 && idne || o || pilu && idne || o) {
if (pilu && idne || o) {
if (o) {
if (idne) {
return true;
}
}
if (cip == 5) {
return true;
}
}
if (pri) {
return true;
}
if (nimint()) {
return true;
}
}
if (pucu) {
return true;
}
if (!iroc) {
return true;
}
return false;
return !iroc && pucu && (nimint() && pri || !sio && tru) && (cip == 5 || pilu) && (idne || o);
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (!pilu && cip != 5 || !tru && !pri || !nimint() || sio && !pri || !nimint() || !pucu || iroc) {
if (!idne) {
return false;
}
if (!o) {
return false;
}
}
return true;
Simplify the following messy chain of conditionals:
if (se == false) {
temast();
}
if (!on && se != false) {
ecli();
} else if (ar == 7 && se != false && on) {
psiel();
}
if (ce == true && se != false && on && ar != 7) {
hinvin();
}
if (veu == true && se != false && on && ar != 7 && ce != true) {
oudzer();
} else if (phue == true && se != false && on && ar != 7 && ce != true && veu != true) {
esteul();
}
if ((dend > pec) == true && se != false && on && ar != 7 && ce != true && veu != true && phue != true) {
cuniou();
}
if (swac == true && se != false && on && ar != 7 && ce != true && veu != true && phue != true && (dend > pec) != true) {
hesm();
} else if (ua != 8 && se != false && on && ar != 7 && ce != true && veu != true && phue != true && (dend > pec) != true && swac != true) {
ingist();
}
{
if (!se) {
temast();
}
if (!on) {
ecli();
}
if (ar == 7) {
psiel();
}
if (ce) {
hinvin();
}
if (veu) {
oudzer();
}
if (phue) {
esteul();
}
if (dend > pec) {
cuniou();
}
if (swac) {
hesm();
}
if (ua != 8) {
ingist();
}
}
Things to double-check in your solution:
== true and == false checks?else if, not just else.Related puzzles: