This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if ((manli() <= 8 && gleNeing() && da == sceda() || deen() && (apal && in || roli() == 6)) && (cles || ril)) {
...
...
// Pretend there is lots of code here
...
...
} else {
mamoss();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (!ril && !cles || (roli() != 6 && (!in || !apal) || !deen()) && (da != sceda() || !gleNeing() || manli() >= 8)) {
mamoss();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (wheNac() || me && kode != 6 && mui) {
if (pheEsmfan() || tiaPesec()) {
if (!pra || e <= 2 && i) {
if (prum() == 2) {
return true;
}
}
}
}
return false;
return prum() == 2 || !pra || e <= 2 && i || pheEsmfan() || tiaPesec() || wheNac() || me && kode != 6 && mui;
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (!me && !wheNac() && !tiaPesec() && !pheEsmfan() && !i && pra && prum() != 2 || e >= 2 && pra && prum() != 2) {
if (kode == 6 && !wheNac() && !tiaPesec() && !pheEsmfan() && !i && pra && prum() != 2 || e >= 2 && pra && prum() != 2) {
if (e >= 2 && pra && prum() != 2) {
if (prum() != 2) {
return false;
}
if (pra) {
return false;
}
if (!i) {
return false;
}
}
if (!pheEsmfan()) {
return false;
}
if (!tiaPesec()) {
return false;
}
if (!wheNac()) {
return false;
}
if (!mui) {
return false;
}
}
}
return true;
Simplify the following messy chain of conditionals:
if (ee) {
sipiss();
} else if (cer == co && !ee) {
cral();
} else if (pi && !ee && cer != co) {
chrir();
}
if (gece == true && !ee && cer != co && !pi) {
iciZexle();
} else if (!scra && !ee && cer != co && !pi && gece != true) {
jais();
}
if (odas == true && !ee && cer != co && !pi && gece != true && scra) {
imca();
}
if (ma == false && !ee && cer != co && !pi && gece != true && scra && odas != true) {
qandit();
} else if (ooss == 8 && !ee && cer != co && !pi && gece != true && scra && odas != true && ma != false) {
pniol();
} else if (od == true && !ee && cer != co && !pi && gece != true && scra && odas != true && ma != false && ooss != 8) {
blak();
}
{
if (ee) {
sipiss();
}
if (cer == co) {
cral();
}
if (pi) {
chrir();
}
if (gece) {
iciZexle();
}
if (!scra) {
jais();
}
if (odas) {
imca();
}
if (!ma) {
qandit();
}
if (ooss == 8) {
pniol();
}
if (od) {
blak();
}
}
Things to double-check in your solution:
== true and == false checks?else if, not just else.Related puzzles: