This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (se && mi && !in && (!os && fo == hiolfa() || rau) || we || scac == ae || awsto() == 1) {
...
...
// Pretend there is lots of code here
...
...
} else {
ioir();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (awsto() != 1 && scac != ae && !we && (!rau && (fo != hiolfa() || os) || in || !mi || !se)) {
ioir();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (riad && orha > 8 || on == 7 || !gi || !chra) {
if (on == 7 || !gi || !chra) {
if (orha > 8) {
return true;
}
}
if (custi() == 1) {
return true;
}
}
if (wocSicis() > 1) {
return true;
}
if (raf == 0) {
return true;
}
if (is != scre()) {
return true;
}
if (scos()) {
return true;
}
return false;
return scos() && is != scre() && raf == 0 && wocSicis() > 1 && (custi() == 1 || riad) && (orha > 8 || on == 7 || !gi || !chra);
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (wocSicis() < 1 || raf != 0 || is == scre() || !scos()) {
if (!riad && custi() != 1) {
if (orha < 8) {
return false;
}
if (on != 7) {
return false;
}
if (gi) {
return false;
}
if (chra) {
return false;
}
}
}
return true;
Simplify the following messy chain of conditionals:
if (bi != uss) {
formoa();
} else if (e == false && bi == uss) {
psicha();
}
if (ia == true && bi == uss && e != false) {
cihad();
} else if ((nir != ourd) == true && bi == uss && e != false && ia != true) {
imsi();
} else if (giss == true && bi == uss && e != false && ia != true && (nir != ourd) != true) {
athIcta();
} else if (siac == false && bi == uss && e != false && ia != true && (nir != ourd) != true && giss != true) {
cluni();
} else if (geas != ilo && bi == uss && e != false && ia != true && (nir != ourd) != true && giss != true && siac != false) {
dinom();
} else if (or == true && bi == uss && e != false && ia != true && (nir != ourd) != true && giss != true && siac != false && geas == ilo) {
oosm();
} else if (mul == false && bi == uss && e != false && ia != true && (nir != ourd) != true && giss != true && siac != false && geas == ilo && or != true) {
asscip();
}
{
if (bi != uss) {
formoa();
}
if (!e) {
psicha();
}
if (ia) {
cihad();
}
if (nir != ourd) {
imsi();
}
if (giss) {
athIcta();
}
if (!siac) {
cluni();
}
if (geas != ilo) {
dinom();
}
if (or) {
oosm();
}
if (!mul) {
asscip();
}
}
Things to double-check in your solution:
== true and == false checks?else if, not just else.Related puzzles: