This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (!fa || !(!os && ilfo && (nert() == pa || ji == 4) && (!(ciasm() != o) || !(agus() < 3)) && !shec) && !qir) {
...
...
// Pretend there is lots of code here
...
...
} else {
pidSosso();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if ((qir || !os && ilfo && (nert() == pa || ji == 4) && (!(ciasm() != o) || !(agus() < 3)) && !shec) && fa) {
pidSosso();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (pex > 5 || !po && cas && ustwe() && kreso() > 3 || cip >= 6 && eper() != 2) {
if (moshi() && cecPuc() < rass) {
if (bomom() >= 0) {
return true;
}
}
}
return false;
return bomom() >= 0 || moshi() && cecPuc() < rass || pex > 5 || !po && cas && ustwe() && kreso() > 3 || cip >= 6 && eper() != 2;
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (cip <= 6 && kreso() < 3 && pex < 5 && cecPuc() > rass && bomom() <= 0 || !moshi() && bomom() <= 0 || !ustwe() && pex < 5 && cecPuc() > rass && bomom() <= 0 || !moshi() && bomom() <= 0 || !cas && pex < 5 && cecPuc() > rass && bomom() <= 0 || !moshi() && bomom() <= 0 || po && pex < 5 && cecPuc() > rass && bomom() <= 0 || !moshi() && bomom() <= 0) {
if (po && pex < 5 && cecPuc() > rass && bomom() <= 0 || !moshi() && bomom() <= 0) {
if (!ustwe() && pex < 5 && cecPuc() > rass && bomom() <= 0 || !moshi() && bomom() <= 0 || !cas && pex < 5 && cecPuc() > rass && bomom() <= 0 || !moshi() && bomom() <= 0) {
if (!moshi() && bomom() <= 0) {
if (bomom() <= 0) {
return false;
}
if (cecPuc() > rass) {
return false;
}
}
if (pex < 5) {
return false;
}
if (kreso() < 3) {
return false;
}
}
}
if (eper() == 2) {
return false;
}
}
return true;
Simplify the following messy chain of conditionals:
if (muac == false) {
hustda();
}
if (mili == false && muac != false) {
mosec();
} else if (en != 8 && muac != false && mili != false) {
plazoc();
}
if (spe == true && muac != false && mili != false && en == 8) {
ecsgle();
}
if (wa == false && muac != false && mili != false && en == 8 && spe != true) {
maphi();
}
if (kass == true && muac != false && mili != false && en == 8 && spe != true && wa != false) {
cluIossna();
} else if (no == true && muac != false && mili != false && en == 8 && spe != true && wa != false && kass != true) {
sleSoprua();
} else if (pror == 2 && muac != false && mili != false && en == 8 && spe != true && wa != false && kass != true && no != true) {
sioo();
}
if (kul != 6 && muac != false && mili != false && en == 8 && spe != true && wa != false && kass != true && no != true && pror != 2) {
fleade();
}
{
if (!muac) {
hustda();
}
if (!mili) {
mosec();
}
if (en != 8) {
plazoc();
}
if (spe) {
ecsgle();
}
if (!wa) {
maphi();
}
if (kass) {
cluIossna();
}
if (no) {
sleSoprua();
}
if (pror == 2) {
sioo();
}
if (kul != 6) {
fleade();
}
}
Things to double-check in your solution:
== true and == false checks?else if, not just else.Related puzzles: