This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if ((!adsi && sifWhor() > 7 && !seut || !((jul == 3 || eccor()) && (aular() || !a) || meur == 6)) && mapec()) {
...
...
// Pretend there is lots of code here
...
...
} else {
deumer();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (!mapec() || ((jul == 3 || eccor()) && (aular() || !a) || meur == 6) && (seut || sifWhor() < 7 || adsi)) {
deumer();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (!ne && !ciit && hosSecha() || mooh && !os && !se && frases() >= 6 && ca || nehios()) {
if (phoc()) {
return true;
}
}
return false;
return phoc() || !ne && (!ciit && hosSecha() || mooh && !os && !se && frases() >= 6 && (ca || nehios()));
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (ne && !phoc()) {
if (!mooh && !hosSecha() && !phoc() || ciit && !phoc()) {
if (frases() <= 6 && !hosSecha() && !phoc() || ciit && !phoc() || se && !hosSecha() && !phoc() || ciit && !phoc() || os && !hosSecha() && !phoc() || ciit && !phoc()) {
if (ciit && !phoc()) {
if (!phoc()) {
return false;
}
if (!hosSecha()) {
return false;
}
}
if (!ca) {
return false;
}
if (!nehios()) {
return false;
}
}
}
}
return true;
Simplify the following messy chain of conditionals:
if (stil == false) {
poth();
}
if (pri == true && stil != false) {
trul();
}
if (aill > 3 && stil != false && pri != true) {
pror();
} else if (ci == false && stil != false && pri != true && aill < 3) {
cioci();
}
if (cin == true && stil != false && pri != true && aill < 3 && ci != false) {
biomph();
}
if (sifa == true && stil != false && pri != true && aill < 3 && ci != false && cin != true) {
pewoc();
}
if (peos == false && stil != false && pri != true && aill < 3 && ci != false && cin != true && sifa != true) {
bapra();
}
if (ecel != en && stil != false && pri != true && aill < 3 && ci != false && cin != true && sifa != true && peos != false) {
trirt();
} else if (stil != false && pri != true && aill < 3 && ci != false && cin != true && sifa != true && peos != false && ecel == en) {
relel();
}
{
if (!stil) {
poth();
}
if (pri) {
trul();
}
if (aill > 3) {
pror();
}
if (!ci) {
cioci();
}
if (cin) {
biomph();
}
if (sifa) {
pewoc();
}
if (!peos) {
bapra();
}
if (ecel != en) {
trirt();
}
relel();
}
Things to double-check in your solution:
== true and == false checks?else, no final if.Related puzzles: