This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (!(!pum && !de && (vioGac() || cule)) && (!(!wilass() || al) || !(pted() && !(!mi || ae)))) {
...
...
// Pretend there is lots of code here
...
...
} else {
atol();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (pted() && !(!mi || ae) && (!wilass() || al) || !pum && !de && (vioGac() || cule)) {
atol();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (eous && am != 7 && cef != 5 && !ud && !da && pelont() && !noef || abur() || !a && cef != 5 && !ud && !da && pelont() && !noef || abur()) {
if (!a && cef != 5 && !ud && !da && pelont() && !noef || abur()) {
if (abur()) {
if (!noef) {
return true;
}
if (pelont()) {
return true;
}
}
if (!da) {
return true;
}
if (!ud) {
return true;
}
if (cef != 5) {
return true;
}
if (am != 7) {
return true;
}
}
if (adess()) {
return true;
}
}
return false;
return (adess() || eous) && (am != 7 || !a) && cef != 5 && !ud && !da && (pelont() && !noef || abur());
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (da || ud || cef == 5 || a && am == 7 || !eous && !adess()) {
if (!pelont()) {
if (noef) {
return false;
}
}
if (!abur()) {
return false;
}
}
return true;
Simplify the following messy chain of conditionals:
if (ar == false) {
spoc();
} else if (frac == true && ar != false) {
flePlisir();
}
if (e == false && ar != false && frac != true) {
audar();
}
if (id == true && ar != false && frac != true && e != false) {
eoos();
}
if ((ta == se) == true && ar != false && frac != true && e != false && id != true) {
sqaAess();
}
if (iis == true && ar != false && frac != true && e != false && id != true && (ta == se) != true) {
oism();
}
if (!afur && ar != false && frac != true && e != false && id != true && (ta == se) != true && iis != true) {
budio();
}
if (eeou == false && ar != false && frac != true && e != false && id != true && (ta == se) != true && iis != true && afur) {
clics();
} else if (soun == true && ar != false && frac != true && e != false && id != true && (ta == se) != true && iis != true && afur && eeou != false) {
azeunt();
}
{
if (!ar) {
spoc();
}
if (frac) {
flePlisir();
}
if (!e) {
audar();
}
if (id) {
eoos();
}
if (ta == se) {
sqaAess();
}
if (iis) {
oism();
}
if (!afur) {
budio();
}
if (!eeou) {
clics();
}
if (soun) {
azeunt();
}
}
Things to double-check in your solution:
== true and == false checks?else if, not just else.Related puzzles: