This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (mo && pra && leel == prar || !maccan() && (virOulmi() || midos() || lecWutrae()) || oper() || en) {
...
...
// Pretend there is lots of code here
...
...
} else {
ertror();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (!en && !oper() && (!lecWutrae() && !midos() && !virOulmi() || maccan()) && (leel != prar || !pra || !mo)) {
ertror();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (sumees() && ho == souc() && chec() || ial && i && pistow() && pri >= 0 && chec() || !mi && chec()) {
if (chec()) {
return true;
}
if (uonNentes() == 9) {
return true;
}
if (espo() < 2) {
return true;
}
}
return false;
return (espo() < 2 && uonNentes() == 9 || sumees() && ho == souc() || ial && (i && pistow() && pri >= 0 || !mi)) && chec();
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (mi && pri <= 0 && ho != souc() && uonNentes() != 9 || espo() > 2 || !sumees() && uonNentes() != 9 || espo() > 2 || !pistow() && ho != souc() && uonNentes() != 9 || espo() > 2 || !sumees() && uonNentes() != 9 || espo() > 2 || !i && ho != souc() && uonNentes() != 9 || espo() > 2 || !sumees() && uonNentes() != 9 || espo() > 2 || !ial && ho != souc() && uonNentes() != 9 || espo() > 2 || !sumees() && uonNentes() != 9 || espo() > 2) {
if (!chec()) {
return false;
}
}
return true;
Simplify the following messy chain of conditionals:
if (bre) {
wiassa();
}
if (ni == gho && !bre) {
resti();
}
if (cu && !bre && ni != gho) {
rithes();
} else if (re > 3 && !bre && ni != gho && !cu) {
bico();
}
if (rar >= 1 && !bre && ni != gho && !cu && re < 3) {
pauma();
}
if ((rhow == io) == true && !bre && ni != gho && !cu && re < 3 && rar <= 1) {
pecost();
} else if (shir == true && !bre && ni != gho && !cu && re < 3 && rar <= 1 && (rhow == io) != true) {
duss();
}
if (ui < ris && !bre && ni != gho && !cu && re < 3 && rar <= 1 && (rhow == io) != true && shir != true) {
pire();
}
if (etul == true && !bre && ni != gho && !cu && re < 3 && rar <= 1 && (rhow == io) != true && shir != true && ui > ris) {
sqebe();
}
{
if (bre) {
wiassa();
}
if (ni == gho) {
resti();
}
if (cu) {
rithes();
}
if (re > 3) {
bico();
}
if (rar >= 1) {
pauma();
}
if (rhow == io) {
pecost();
}
if (shir) {
duss();
}
if (ui < ris) {
pire();
}
if (etul) {
sqebe();
}
}
Things to double-check in your solution:
== true and == false checks?else if, not just else.Related puzzles: