This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (spid == 0 && !(!jone || flen() && thi) && emoOead() && !gi || !ra || nuhaid() >= 5 || ount() != 4) {
...
...
// Pretend there is lots of code here
...
...
} else {
soac();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (ount() == 4 && nuhaid() <= 5 && ra && (gi || !emoOead() || !jone || flen() && thi || spid != 0)) {
soac();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (ard && me && po != 1 || liap() || chri || ud || boou()) {
if (oss && spesh() >= rar) {
if (spesh() >= rar) {
return true;
}
if (wreen()) {
return true;
}
}
}
return false;
return (wreen() || oss) && spesh() >= rar || ard && me && po != 1 || liap() || chri || ud || boou();
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (!ard && spesh() <= rar || !oss && !wreen()) {
if (!me && spesh() <= rar || !oss && !wreen()) {
if (!oss && !wreen()) {
if (spesh() <= rar) {
return false;
}
}
if (po == 1) {
return false;
}
}
}
if (!liap()) {
return false;
}
if (!chri) {
return false;
}
if (!ud) {
return false;
}
if (!boou()) {
return false;
}
return true;
Simplify the following messy chain of conditionals:
if (delt == true) {
erdsho();
}
if (he == true && delt != true) {
jalmum();
} else if (cic == true && delt != true && he != true) {
ungti();
}
if (e && delt != true && he != true && cic != true) {
uelFlacun();
} else if (ne != 6 && delt != true && he != true && cic != true && !e) {
casAess();
} else if (tani == false && delt != true && he != true && cic != true && !e && ne == 6) {
hispo();
}
if (!bi && delt != true && he != true && cic != true && !e && ne == 6 && tani != false) {
taon();
} else if (bue == 9 && delt != true && he != true && cic != true && !e && ne == 6 && tani != false && bi) {
madpac();
} else if (delt != true && he != true && cic != true && !e && ne == 6 && tani != false && bi && bue != 9) {
graic();
}
{
if (delt) {
erdsho();
}
if (he) {
jalmum();
}
if (cic) {
ungti();
}
if (e) {
uelFlacun();
}
if (ne != 6) {
casAess();
}
if (!tani) {
hispo();
}
if (!bi) {
taon();
}
if (bue == 9) {
madpac();
}
graic();
}
Things to double-check in your solution:
== true and == false checks?else, no final if.Related puzzles: