This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (!ru || !as || esan != eoru && gomost() == re || !(smoc() == criEgerch()) && (trol() || nopZundod()) || ceaGren() || prun == 8) {
...
...
// Pretend there is lots of code here
...
...
} else {
orstea();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (prun != 8 && !ceaGren() && (!nopZundod() && !trol() || smoc() == criEgerch()) && (gomost() != re || esan == eoru) && as && ru) {
orstea();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (e < 5 && elwo() && uchGeis() && !we && !ta && pleng() || lavu() || !hi && pleng() || lavu()) {
if (fiec && !ta && pleng() || lavu() || !hi && pleng() || lavu()) {
if (!hi && pleng() || lavu()) {
if (lavu()) {
if (pleng()) {
return true;
}
}
if (!ta) {
return true;
}
}
if (abi) {
return true;
}
}
}
return false;
return (abi || fiec || e < 5 && elwo() && uchGeis() && !we) && (!ta || !hi) && (pleng() || lavu());
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (hi && ta || we && !fiec && !abi || !uchGeis() && !fiec && !abi || !elwo() && !fiec && !abi || e > 5 && !fiec && !abi) {
if (!pleng()) {
return false;
}
if (!lavu()) {
return false;
}
}
return true;
Simplify the following messy chain of conditionals:
if ((uno >= 0) == true) {
dretpa();
} else if (er < 8 == true && (uno >= 0) != true) {
plaAodho();
}
if (!apru && (uno >= 0) != true && er < 8 != true) {
herda();
} else if (a == false && (uno >= 0) != true && er < 8 != true && apru) {
biss();
}
if (ces == false && (uno >= 0) != true && er < 8 != true && apru && a != false) {
xipIachio();
} else if (be == false && (uno >= 0) != true && er < 8 != true && apru && a != false && ces != false) {
prerd();
} else if (mepi == 6 && (uno >= 0) != true && er < 8 != true && apru && a != false && ces != false && be != false) {
hiia();
}
if (phah >= 0 && (uno >= 0) != true && er < 8 != true && apru && a != false && ces != false && be != false && mepi != 6) {
prerhe();
}
if ((uno >= 0) != true && er < 8 != true && apru && a != false && ces != false && be != false && mepi != 6 && phah <= 0) {
clesgi();
}
{
if (uno >= 0) {
dretpa();
}
if (er < 8) {
plaAodho();
}
if (!apru) {
herda();
}
if (!a) {
biss();
}
if (!ces) {
xipIachio();
}
if (!be) {
prerd();
}
if (mepi == 6) {
hiia();
}
if (phah >= 0) {
prerhe();
}
clesgi();
}
Things to double-check in your solution:
== true and == false checks?else, no final if.Related puzzles: