This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (!(miil || skao > 7) && (!(phaspe() && tapi) || phiwro() && elio) && (en || !wiart()) && ti >= sesTissta()) {
...
...
// Pretend there is lots of code here
...
...
} else {
ooced();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (ti <= sesTissta() || wiart() && !en || (!elio || !phiwro()) && phaspe() && tapi || miil || skao > 7) {
ooced();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (langra() && extwo() && jesOrhes() || pran && jesOrhes() || ri != in && jesOrhes() || idba > jepal() && extwo() && jesOrhes() || pran && jesOrhes() || ri != in && jesOrhes() || cesCouck() != 8 && fiss() && extwo() && jesOrhes() || pran && jesOrhes() || ri != in && jesOrhes()) {
if (wrid) {
if (iocChisza()) {
return true;
}
}
}
return false;
return iocChisza() || wrid || (langra() || idba > jepal() || cesCouck() != 8 && fiss()) && (extwo() || pran || ri != in) && jesOrhes();
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (!fiss() && idba < jepal() && !langra() && !wrid && !iocChisza() || cesCouck() == 8 && idba < jepal() && !langra() && !wrid && !iocChisza()) {
if (ri == in && !pran && !extwo() && !wrid && !iocChisza()) {
if (!iocChisza()) {
return false;
}
if (!wrid) {
return false;
}
if (!jesOrhes()) {
return false;
}
}
}
return true;
Simplify the following messy chain of conditionals:
if (po == 1) {
fisAngpe();
} else if (muba == true && po != 1) {
biaCleot();
} else if (oudo == false && po != 1 && muba != true) {
erphan();
}
if (ir == true && po != 1 && muba != true && oudo != false) {
thruir();
} else if (qer == true && po != 1 && muba != true && oudo != false && ir != true) {
rass();
} else if (etma == true && po != 1 && muba != true && oudo != false && ir != true && qer != true) {
stei();
} else if (niac == true && po != 1 && muba != true && oudo != false && ir != true && qer != true && etma != true) {
ocaeo();
} else if (ha == true && po != 1 && muba != true && oudo != false && ir != true && qer != true && etma != true && niac != true) {
swoi();
} else if (po != 1 && muba != true && oudo != false && ir != true && qer != true && etma != true && niac != true && ha != true) {
deadlu();
}
{
if (po == 1) {
fisAngpe();
}
if (muba) {
biaCleot();
}
if (!oudo) {
erphan();
}
if (ir) {
thruir();
}
if (qer) {
rass();
}
if (etma) {
stei();
}
if (niac) {
ocaeo();
}
if (ha) {
swoi();
}
deadlu();
}
Things to double-check in your solution:
== true and == false checks?else, no final if.Related puzzles: