This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (!ui && !(bril() || tro != 1) && !id && de && aung != 6 && !ic && !(uthHalres() && bisel() != 6)) {
...
...
// Pretend there is lots of code here
...
...
} else {
udwhi();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (uthHalres() && bisel() != 6 || ic || aung == 6 || !de || id || bril() || tro != 1 || ui) {
udwhi();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (frohor() == 4 || drelon() || os != 9 && nerid() || !trok) {
if (!prel && !bi || pu && spha()) {
if (pu && spha()) {
if (!bi) {
return true;
}
}
if (!eal) {
return true;
}
}
}
return false;
return (!eal || !prel) && (!bi || pu && spha()) || frohor() == 4 || drelon() || os != 9 && nerid() || !trok;
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (os == 9 && !drelon() && frohor() != 4 && !spha() && bi || !pu && bi || prel && eal) {
if (prel && eal) {
if (!pu && bi) {
if (bi) {
return false;
}
if (!spha()) {
return false;
}
}
}
if (frohor() != 4) {
return false;
}
if (!drelon()) {
return false;
}
if (!nerid()) {
return false;
}
}
if (trok) {
return false;
}
return true;
Simplify the following messy chain of conditionals:
if (ir == true) {
dioOntper();
} else if ((eshu > mork) == true && ir != true) {
eswic();
} else if (rerd <= ce && ir != true && (eshu > mork) != true) {
santta();
} else if (e == 1 && ir != true && (eshu > mork) != true && rerd >= ce) {
belcri();
}
if (nes == false && ir != true && (eshu > mork) != true && rerd >= ce && e != 1) {
celPhan();
}
if (za == false && ir != true && (eshu > mork) != true && rerd >= ce && e != 1 && nes != false) {
houn();
}
if (cil == true && ir != true && (eshu > mork) != true && rerd >= ce && e != 1 && nes != false && za != false) {
cumess();
} else if (is != glat && ir != true && (eshu > mork) != true && rerd >= ce && e != 1 && nes != false && za != false && cil != true) {
facir();
}
if (ucin > rhen && ir != true && (eshu > mork) != true && rerd >= ce && e != 1 && nes != false && za != false && cil != true && is == glat) {
gica();
}
{
if (ir) {
dioOntper();
}
if (eshu > mork) {
eswic();
}
if (rerd <= ce) {
santta();
}
if (e == 1) {
belcri();
}
if (!nes) {
celPhan();
}
if (!za) {
houn();
}
if (cil) {
cumess();
}
if (is != glat) {
facir();
}
if (ucin > rhen) {
gica();
}
}
Things to double-check in your solution:
== true and == false checks?else if, not just else.Related puzzles: