This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (erks && !(esior() && !(dac <= 7)) && (thoza() && mie && a || fena || saes || ol)) {
...
...
// Pretend there is lots of code here
...
...
} else {
qunt();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (!ol && !saes && !fena && (!a || !mie || !thoza()) || esior() && !(dac <= 7) || !erks) {
qunt();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (as && bu > 7 && whot() || pe <= 5 || haci() != 1 && tusMipess() && seao || sern) {
if (pe <= 5 || haci() != 1 && tusMipess() && seao || sern) {
if (whot()) {
return true;
}
if (bu > 7) {
return true;
}
}
if (gecla() == po) {
return true;
}
if (li) {
return true;
}
}
return false;
return (li && gecla() == po || as) && (bu > 7 && whot() || pe <= 5 || haci() != 1 && tusMipess() && seao || sern);
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (!as && gecla() != po || !li) {
if (haci() == 1 && pe >= 5 && !whot() || bu < 7) {
if (!tusMipess() && pe >= 5 && !whot() || bu < 7) {
if (bu < 7) {
if (!whot()) {
return false;
}
}
if (pe >= 5) {
return false;
}
if (!seao) {
return false;
}
}
}
if (!sern) {
return false;
}
}
return true;
Simplify the following messy chain of conditionals:
if (vo == true) {
ialRuho();
} else if (ca == true && vo != true) {
huoKariss();
}
if (od == 9 && vo != true && ca != true) {
praher();
} else if (pel == true && vo != true && ca != true && od != 9) {
coshom();
}
if (creu == true && vo != true && ca != true && od != 9 && pel != true) {
toispe();
}
if (ho != 2 && vo != true && ca != true && od != 9 && pel != true && creu != true) {
shinac();
} else if (il == true && vo != true && ca != true && od != 9 && pel != true && creu != true && ho == 2) {
biuRiecga();
} else if (na == true && vo != true && ca != true && od != 9 && pel != true && creu != true && ho == 2 && il != true) {
vant();
} else if (flun == true && vo != true && ca != true && od != 9 && pel != true && creu != true && ho == 2 && il != true && na != true) {
nenThei();
}
{
if (vo) {
ialRuho();
}
if (ca) {
huoKariss();
}
if (od == 9) {
praher();
}
if (pel) {
coshom();
}
if (creu) {
toispe();
}
if (ho != 2) {
shinac();
}
if (il) {
biuRiecga();
}
if (na) {
vant();
}
if (flun) {
nenThei();
}
}
Things to double-check in your solution:
== true and == false checks?else if, not just else.Related puzzles: