This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (ploi && !(!cip && (kehes() || splec() == 4 || gloZoaple()) && !mo && (!(eour() || skened()) || psaent()))) {
...
...
// Pretend there is lots of code here
...
...
} else {
booi();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (!cip && (kehes() || splec() == 4 || gloZoaple()) && !mo && (!(eour() || skened()) || psaent()) || !ploi) {
booi();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (cec && ris && li && cao < 2 || scoran() && cao < 2 || stio == he && cao < 2 || bi < puda() && cao < 2 || omon == 2 && cao < 2 || acsont() && cao < 2) {
if (bi < puda() && cao < 2 || omon == 2 && cao < 2 || acsont() && cao < 2) {
if (scoran() && cao < 2 || stio == he && cao < 2) {
if (cao < 2) {
return true;
}
if (li) {
return true;
}
}
}
if (ris) {
return true;
}
if (a) {
return true;
}
}
return false;
return (a || cec) && ris && (li || scoran() || stio == he || bi < puda() || omon == 2 || acsont()) && cao < 2;
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (!cec && !a) {
if (!ris) {
if (!acsont() && omon != 2 && bi > puda() && stio != he && !scoran() && !li) {
if (cao > 2) {
return false;
}
}
}
}
return true;
Simplify the following messy chain of conditionals:
if (ra == true) {
oloNac();
} else if (ang != 9 && ra != true) {
usang();
}
if (scha > 6 && ra != true && ang == 9) {
bonic();
}
if (dus == false && ra != true && ang == 9 && scha < 6) {
doslou();
}
if (ma == true && ra != true && ang == 9 && scha < 6 && dus != false) {
ecmoc();
}
if (kock == true && ra != true && ang == 9 && scha < 6 && dus != false && ma != true) {
iusmem();
}
if (meid && ra != true && ang == 9 && scha < 6 && dus != false && ma != true && kock != true) {
prart();
}
if (si > flir && ra != true && ang == 9 && scha < 6 && dus != false && ma != true && kock != true && !meid) {
xurBintod();
}
if (in != se && ra != true && ang == 9 && scha < 6 && dus != false && ma != true && kock != true && !meid && si < flir) {
oent();
}
{
if (ra) {
oloNac();
}
if (ang != 9) {
usang();
}
if (scha > 6) {
bonic();
}
if (!dus) {
doslou();
}
if (ma) {
ecmoc();
}
if (kock) {
iusmem();
}
if (meid) {
prart();
}
if (si > flir) {
xurBintod();
}
if (in != se) {
oent();
}
}
Things to double-check in your solution:
== true and == false checks?else if, not just else.Related puzzles: