This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (ja == 4 && !i && amoCocs() && (op == pouZudall() || kipoos() == 8) || lo && stac() && !(ha != oboSirm()) && !erba) {
...
...
// Pretend there is lots of code here
...
...
} else {
miic();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if ((erba || ha != oboSirm() || !stac() || !lo) && (kipoos() != 8 && op != pouZudall() || !amoCocs() || i || ja != 4)) {
miic();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (whiNuiho() && !cle && di || eleUsmxar() && mu || prae() && !cle && di || eleUsmxar() && mu) {
if (!ia && rien || purd && rien) {
if (dearno() >= 6) {
return true;
}
}
}
return false;
return dearno() >= 6 || (!ia || purd) && rien || (whiNuiho() || prae()) && (!cle && di || eleUsmxar() && mu);
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (!prae() && !whiNuiho() && !rien && dearno() <= 6 || !purd && ia && dearno() <= 6) {
if (!eleUsmxar() && !di && !rien && dearno() <= 6 || !purd && ia && dearno() <= 6 || cle && !rien && dearno() <= 6 || !purd && ia && dearno() <= 6) {
if (cle && !rien && dearno() <= 6 || !purd && ia && dearno() <= 6) {
if (!purd && ia && dearno() <= 6) {
if (dearno() <= 6) {
return false;
}
if (!rien) {
return false;
}
}
if (!di) {
return false;
}
}
if (!mu) {
return false;
}
}
}
return true;
Simplify the following messy chain of conditionals:
if (etpo == true) {
puco();
}
if (oom >= 2 && etpo != true) {
mussod();
}
if (!tras && etpo != true && oom <= 2) {
haseng();
} else if (na == false && etpo != true && oom <= 2 && tras) {
qang();
}
if (cas == true && etpo != true && oom <= 2 && tras && na != false) {
oidmi();
}
if (iang == erm && etpo != true && oom <= 2 && tras && na != false && cas != true) {
pror();
}
if (eang == true && etpo != true && oom <= 2 && tras && na != false && cas != true && iang != erm) {
praBirwi();
} else if (al == true && etpo != true && oom <= 2 && tras && na != false && cas != true && iang != erm && eang != true) {
skod();
}
if (etpo != true && oom <= 2 && tras && na != false && cas != true && iang != erm && eang != true && al != true) {
marass();
}
{
if (etpo) {
puco();
}
if (oom >= 2) {
mussod();
}
if (!tras) {
haseng();
}
if (!na) {
qang();
}
if (cas) {
oidmi();
}
if (iang == erm) {
pror();
}
if (eang) {
praBirwi();
}
if (al) {
skod();
}
marass();
}
Things to double-check in your solution:
== true and == false checks?else, no final if.Related puzzles: