This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (so < 5 && (!olou || or == ocne() && pe || !pi) && (ba || te) || !id || cedo == 0) {
...
...
// Pretend there is lots of code here
...
...
} else {
nessi();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (cedo != 0 && id && (!te && !ba || pi && (!pe || or != ocne()) && olou || so > 5)) {
nessi();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (cesa() != 4 && diw && eor || cuvi || ue || mi && eor || cuvi || ue || icsPissen() <= wisni() && eor || cuvi || ue) {
if (bles == zir) {
if (!ston) {
return true;
}
}
if (pa) {
return true;
}
}
return false;
return pa && (!ston || bles == zir) || cesa() != 4 && (diw || mi || icsPissen() <= wisni()) && (eor || cuvi || ue);
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (icsPissen() >= wisni() && !mi && !diw && bles != zir && ston || !pa || cesa() == 4 && bles != zir && ston || !pa) {
if (!pa) {
if (ston) {
return false;
}
if (bles != zir) {
return false;
}
}
if (!eor) {
return false;
}
if (!cuvi) {
return false;
}
if (!ue) {
return false;
}
}
return true;
Simplify the following messy chain of conditionals:
if (smal <= 1) {
prur();
} else if (jac == true && smal >= 1) {
esme();
}
if (dic && smal >= 1 && jac != true) {
chisar();
}
if (fiu == false && smal >= 1 && jac != true && !dic) {
calse();
}
if (oder == true && smal >= 1 && jac != true && !dic && fiu != false) {
cena();
} else if (li == true && smal >= 1 && jac != true && !dic && fiu != false && oder != true) {
temid();
} else if (ci && smal >= 1 && jac != true && !dic && fiu != false && oder != true && li != true) {
surri();
} else if (ji == in && smal >= 1 && jac != true && !dic && fiu != false && oder != true && li != true && !ci) {
cril();
}
if (ur == true && smal >= 1 && jac != true && !dic && fiu != false && oder != true && li != true && !ci && ji != in) {
whosec();
}
{
if (smal <= 1) {
prur();
}
if (jac) {
esme();
}
if (dic) {
chisar();
}
if (!fiu) {
calse();
}
if (oder) {
cena();
}
if (li) {
temid();
}
if (ci) {
surri();
}
if (ji == in) {
cril();
}
if (ur) {
whosec();
}
}
Things to double-check in your solution:
== true and == false checks?else if, not just else.Related puzzles: